Fall-back to OpenGL renderer if mac hardware doesn't support Metal

Fall-back to OpenGL renderer if mac hardware doesn't support Metal

BUG=webrtc:7782
Review-Url: https://codereview.webrtc.org/2927983002
Cr-Commit-Position: refs/heads/master@{#18539}
Committed: https://chromium.googlesource.com/external/webrtc/+/42742a56efbe4726555339a0e1a7858f8563a8f0

[afedor, 2017-06-08 19:00:10]

Description was changed from

==========
Fall-back to OpenGL renderer if mac hardware doesn't support Metal

BUG=webrtc:7782
==========

to

==========
Fall-back to OpenGL renderer if mac hardware doesn't support Metal

BUG=webrtc:7782
==========

[afedor, 2017-06-08 19:00:10]

adam.fedor@gmail.com changed reviewers:
+ magjed@webrtc.org

[magjed_webrtc, 2017-06-09 08:16:07]

magjed@webrtc.org changed reviewers:
+ denicija@webrtc.org

[magjed_webrtc, 2017-06-09 08:17:09]

Daniela - please take a look.

[daniela-webrtc, 2017-06-09 09:04:44]

On 2017/06/09 08:17:09, magjed_webrtc wrote:
> Daniela - please take a look.

Hi Fedor
Thank you for the patch.
The reason why we didn't implement this initially was because -initWithFrame is
defined as returning non-nil instance.  And I really dislike breaking the method
signature like this.
On iOS we have macro for checking if there is Metal support and we use it as a
workaround for this. Is there something similar that can be used on Mac as well?

[afedor, 2017-06-09 14:47:45]

The "commonly accepted" runtime method of checking if Metal is available is to
check if there are any Metal devices (https://stackoverflow.com/a/40485458), so
I've implemented +isMetalAvailable to do this.  (Note I chose one of the
non-accepted answers which describes why you should use MTLCopyAllDevices() and
not MTLCreateSystemDefaultDevice())

[daniela-webrtc, 2017-06-12 09:35:41]

On 2017/06/09 14:47:45, afedor wrote:
> The "commonly accepted" runtime method of checking if Metal is available is to
> check if there are any Metal devices (https://stackoverflow.com/a/40485458),
so
> I've implemented +isMetalAvailable to do this.  (Note I chose one of the
> non-accepted answers which describes why you should use MTLCopyAllDevices()
and
> not MTLCreateSystemDefaultDevice())

This works nicely. Thank you so much for the patch and for the thorough
implementation.
LGTM

[magjed_webrtc, 2017-06-12 13:24:22]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-06-12 13:24:22]

lgtm

[commit-bot: I haz the power, 2017-06-12 13:24:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 14:32:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497273862252660,
"parent_rev": "84b4d2c1c2db7f65c3d67238ce4af0042885ac97", "commit_rev":
"42742a56efbe4726555339a0e1a7858f8563a8f0"}

[commit-bot: I haz the power, 2017-06-12 14:32:13]

Description was changed from

==========
Fall-back to OpenGL renderer if mac hardware doesn't support Metal

BUG=webrtc:7782
==========

to

==========
Fall-back to OpenGL renderer if mac hardware doesn't support Metal

BUG=webrtc:7782

Review-Url: https://codereview.webrtc.org/2927983002
Cr-Commit-Position: refs/heads/master@{#18539}
Committed:
https://chromium.googlesource.com/external/webrtc/+/42742a56efbe4726555339a0e...
==========

[commit-bot: I haz the power, 2017-06-12 14:32:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/42742a56efbe4726555339a0e...