Update VirtualSocketServerTest to use a fake clock.

Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any "real" thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

Lastly, added a DCHECK in Thread::ProcessMessages. If called with a
nonzero time while a fake clock is used, it will get stuck in an
infinite loop; a DCHECK is easier to notice than an infinite loop.

BUG=webrtc:7727, webrtc:2409
Review-Url: https://codereview.webrtc.org/2927413002
Cr-Commit-Position: refs/heads/master@{#18544}
Committed: https://chromium.googlesource.com/external/webrtc/+/22e0814d51ba730cb8a8eb420b1041e8e6e6ffd8

[Taylor Brandstetter, 2017-06-09 23:15:20]

Description was changed from

==========
Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any physical thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

BUG=webrtc:7727, webrtc:2409
==========

to

==========
Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any physical thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

Lastly, added a DCHECK in Thread::ProcessMessages. If called with a
nonzero time while a fake clock is used, it will get stuck in an
infinite loop; a DCHECK is easier to notice than an infinite loop.

BUG=webrtc:7727, webrtc:2409
==========

[Taylor Brandstetter, 2017-06-09 23:16:25]

deadbeef@webrtc.org changed reviewers:
+ kjellander@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2017-06-09 23:16:26]

pthatcher: PTAL, or suggest another reviewer.
kjellander: CC'ed you since this is related to
https://codereview.webrtc.org/2909073002/

[Taylor Brandstetter, 2017-06-09 23:16:49]

Description was changed from

==========
Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any physical thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

Lastly, added a DCHECK in Thread::ProcessMessages. If called with a
nonzero time while a fake clock is used, it will get stuck in an
infinite loop; a DCHECK is easier to notice than an infinite loop.

BUG=webrtc:7727, webrtc:2409
==========

to

==========
Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any "real" thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

Lastly, added a DCHECK in Thread::ProcessMessages. If called with a
nonzero time while a fake clock is used, it will get stuck in an
infinite loop; a DCHECK is easier to notice than an infinite loop.

BUG=webrtc:7727, webrtc:2409
==========

[Taylor Brandstetter, 2017-06-09 23:18:30]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 23:18:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-09 23:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 23:29:03]

Dry run: Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/26843)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/26228)

[pthatcher, 2017-06-10 03:06:28]

pthatcher@google.com changed reviewers:
+ pthatcher@google.com

[pthatcher, 2017-06-10 03:06:29]

lgtm

[Taylor Brandstetter, 2017-06-12 19:24:01]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 19:24:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 20:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:03:15]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-06-12 20:33:23]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-06-12 20:33:23]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@google.com
Link to the patchset: https://codereview.webrtc.org/2927413002/#ps20001 (title:
"Allow ProcessMessages with cmsLoop of kForever.")

[commit-bot: I haz the power, 2017-06-12 20:33:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 20:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:33:27]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[pthatcher1, 2017-06-12 20:45:50]

lgtm

[Taylor Brandstetter, 2017-06-12 21:28:20]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-06-12 21:28:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 21:30:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497302900226460,
"parent_rev": "36b1a5fcec6270ec4a5bea87b33a49b418a3cb29", "commit_rev":
"22e0814d51ba730cb8a8eb420b1041e8e6e6ffd8"}

[commit-bot: I haz the power, 2017-06-12 21:30:33]

Description was changed from

==========
Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any "real" thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

Lastly, added a DCHECK in Thread::ProcessMessages. If called with a
nonzero time while a fake clock is used, it will get stuck in an
infinite loop; a DCHECK is easier to notice than an infinite loop.

BUG=webrtc:7727, webrtc:2409
==========

to

==========
Update VirtualSocketServerTest to use a fake clock.

Since this is a test for a fake network, it's only natural that it uses
a fake clock as well. This makes the tests much faster, less flaky, and
lets them be moved out of  "webrtc_nonparallel_tests", since they no
longer have a dependency on any "real" thing (sockets, or time) and
can be run in parallel as easily as any other tests.

As part of this CL, added the fake clock as an argument to
VirtualSocketServer's and TestClient's constructors, since these classes
have methods that wait synchronously for something to occur, and if the
test is using a fake clock, they need to advance it in order to make
progress.

Lastly, added a DCHECK in Thread::ProcessMessages. If called with a
nonzero time while a fake clock is used, it will get stuck in an
infinite loop; a DCHECK is easier to notice than an infinite loop.

BUG=webrtc:7727, webrtc:2409

Review-Url: https://codereview.webrtc.org/2927413002
Cr-Commit-Position: refs/heads/master@{#18544}
Committed:
https://chromium.googlesource.com/external/webrtc/+/22e0814d51ba730cb8a8eb420...
==========

[commit-bot: I haz the power, 2017-06-12 21:30:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/22e0814d51ba730cb8a8eb420...