Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2926713007: Delete unused method FilesystemInterface::GetFileTime. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused method FilesystemInterface::GetFileTime. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2926713007 Cr-Commit-Position: refs/heads/master@{#18564} Committed: https://chromium.googlesource.com/external/webrtc/+/a65ad229390742d08f2843140a7f992e3af0356f

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M webrtc/base/fileutils.h View 1 3 chunks +0 lines, -11 lines 0 comments Download
M webrtc/base/unixfilesystem.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 1 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/base/win32filesystem.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/win32filesystem.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
nisse-webrtc
PTAL. I do these deletions as separate cls, so they can be tested and possibly ...
3 years, 6 months ago (2017-06-09 13:24:18 UTC) #2
Taylor Brandstetter
lgtm
3 years, 6 months ago (2017-06-09 21:33:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2926713007/20001
3 years, 6 months ago (2017-06-13 12:35:43 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 12:37:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/a65ad229390742d08f2843140...

Powered by Google App Engine
This is Rietveld 408576698