Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2926273002: Add missing #include <cerrno> in string_to_number.cc (Closed)

Created:
3 years, 6 months ago by hugoh_UTC2
Modified:
3 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add missing #include <cerrno> in string_to_number.cc One of our toolchains does not expose |errno| in the global namespace. BUG=none Review-Url: https://codereview.webrtc.org/2926273002 Cr-Commit-Position: refs/heads/master@{#18506} Committed: https://chromium.googlesource.com/external/webrtc/+/6baee78bc9c72e96e4600bc17ccfb476dd558583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/base/string_to_number.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hugoh_UTC2
kwiberg@ could you PTAL at this trival change?
3 years, 6 months ago (2017-06-08 13:17:32 UTC) #2
kwiberg-webrtc
lgtm
3 years, 6 months ago (2017-06-08 23:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2926273002/1
3 years, 6 months ago (2017-06-08 23:10:29 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 23:38:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6baee78bc9c72e96e4600bc17...

Powered by Google App Engine
This is Rietveld 408576698