Move MinPositive to call.h

Move MinPositive to call.h as discussed here: https://codereview.chromium.org/2888303005/#msg19

TBR=stefan@webrtc.org
BUG=webrtc:7395
Review-Url: https://codereview.webrtc.org/2924393002
Cr-Commit-Position: refs/heads/master@{#18599}
Committed: https://chromium.googlesource.com/external/webrtc/+/a5e0df643828c1d16ce3b508849d0c4ed6130081

[Zach Stein, 2017-06-08 22:10:41]

Description was changed from

==========
Move MinPositive to call.h

BUG=webrtc:7395
==========

to

==========
Move MinPositive to call.h as discussed here:
https://codereview.chromium.org/2888303005/#msg19

BUG=webrtc:7395
==========

[Zach Stein, 2017-06-08 22:10:41]

zstein@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, stefan@webrtc.org

[Zach Stein, 2017-06-08 22:10:57]

PTAL

[Taylor Brandstetter, 2017-06-09 17:43:58]

lgtm

https://codereview.webrtc.org/2924393002/diff/1/webrtc/call/call.h
File webrtc/call/call.h (right):

https://codereview.webrtc.org/2924393002/diff/1/webrtc/call/call.h#newcode44
webrtc/call/call.h:44: static T MinPositive(T a, T b) {
As long as we're moving this, can we add a comment explaining why it exists
(because we use "-1" to represent unset values, and sometimes need to take the
minimum of two maximums)? Just so it doesn't confuse people again in the future.
Could also add a TODO for removing or replacing it once we switch to
rtc::Optional

[holmer, 2017-06-12 11:46:55]

holmer@google.com changed reviewers:
+ holmer@google.com

[holmer, 2017-06-12 11:46:56]

lgtm

https://codereview.webrtc.org/2924393002/diff/1/webrtc/call/call.h
File webrtc/call/call.h (right):

https://codereview.webrtc.org/2924393002/diff/1/webrtc/call/call.h#newcode44
webrtc/call/call.h:44: static T MinPositive(T a, T b) {
On 2017/06/09 17:43:58, Taylor Brandstetter wrote:
> As long as we're moving this, can we add a comment explaining why it exists
> (because we use "-1" to represent unset values, and sometimes need to take the
> minimum of two maximums)? Just so it doesn't confuse people again in the
future.
> Could also add a TODO for removing or replacing it once we switch to
> rtc::Optional

+1

[Zach Stein, 2017-06-13 17:31:11]

The CQ bit was checked by zstein@webrtc.org

[Zach Stein, 2017-06-13 17:31:11]

The patchset sent to the CQ was uploaded after l-g-t-m from holmer@google.com,
deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2924393002/#ps20001 (title:
"Add a comment and TODO to MinPositive.")

[commit-bot: I haz the power, 2017-06-13 17:31:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-13 17:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:32:56]

Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/26431)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/25394)

[Zach Stein, 2017-06-13 17:37:52]

The CQ bit was checked by zstein@webrtc.org

[Zach Stein, 2017-06-13 17:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from holmer@google.com,
deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2924393002/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-06-13 17:37:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-13 17:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:42:25]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18124)

[Zach Stein, 2017-06-14 18:13:47]

Description was changed from

==========
Move MinPositive to call.h as discussed here:
https://codereview.chromium.org/2888303005/#msg19

BUG=webrtc:7395
==========

to

==========
Move MinPositive to call.h as discussed here:
https://codereview.chromium.org/2888303005/#msg19

TBR=stefan@webrtc.org
BUG=webrtc:7395
==========

[Zach Stein, 2017-06-14 18:14:03]

The CQ bit was checked by zstein@webrtc.org

[commit-bot: I haz the power, 2017-06-14 18:14:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-14 18:41:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497464043692650,
"parent_rev": "23bc51bd875d8b4f23d20d3e37026fdefaa4741a", "commit_rev":
"a5e0df643828c1d16ce3b508849d0c4ed6130081"}

[commit-bot: I haz the power, 2017-06-14 18:41:53]

Description was changed from

==========
Move MinPositive to call.h as discussed here:
https://codereview.chromium.org/2888303005/#msg19

TBR=stefan@webrtc.org
BUG=webrtc:7395
==========

to

==========
Move MinPositive to call.h as discussed here:
https://codereview.chromium.org/2888303005/#msg19

TBR=stefan@webrtc.org
BUG=webrtc:7395

Review-Url: https://codereview.webrtc.org/2924393002
Cr-Commit-Position: refs/heads/master@{#18599}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5e0df643828c1d16ce3b5088...
==========

[commit-bot: I haz the power, 2017-06-14 18:41:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a5e0df643828c1d16ce3b5088...