Revert of Add support for multiple pixel formats in VideoFrameBuffer

Revert of Add support for multiple pixel formats in VideoFrameBuffer (patchset #7 id:320001 of https://codereview.webrtc.org/2847383002/ )

Reason for revert:
Suspect of breaking FYI bots.
See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win8%20Tester/builds/655/steps/content_browsertests/logs/stdio

[4100:4488:0607/163040.910:9150875:FATAL:webrtc_video_frame_adapter.cc(98)] Check failed: false. 
Backtrace:
	base::debug::StackTrace::StackTrace [0x01CD71F7+55]
	base::debug::StackTrace::StackTrace [0x01CF179A+10]
	content::WebRtcVideoFrameAdapter::NativeToI420Buffer [0x03229C01+305]
	webrtc::VideoFrameBuffer::ToI420 [0x012640E7+39]
	webrtc::VP8EncoderImpl::Encode [0x036DAA93+179]
	webrtc::VCMGenericEncoder::Encode [0x036D04B4+333]
	webrtc::vcm::VideoSender::AddVideoFrame [0x036CE35B+796]
	webrtc::ViEEncoder::EncodeVideoFrame [0x036AF2E6+884]
	webrtc::ViEEncoder::EncodeTask::Run [0x036B04C7+215]
	rtc::TaskQueue::PostTask [0x02847B8B+194]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(std::unique_ptr<webcrypto::`anonymous namespace'::DeriveBitsState,std::default_delete<webcrypto::`anonymous namespace'::DeriveBitsState> >),base::internal::PassedWrapper<std::unique_ptr<web [0x01143F3E+31]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(std::unique_ptr<webcrypto::`anonymous namespace'::DeriveBitsState,std::default_delete<webcrypto::`anonymous namespace'::DeriveBitsState> >),base::internal::PassedWrapper<std::unique_ptr<web [0x01148086+22]
	base::debug::TaskAnnotator::RunTask [0x01CFD279+409]
	base::MessageLoop::RunTask [0x01C8FFF1+1233]
	base::MessageLoop::DoWork [0x01C8F3AD+765]
	base::MessagePumpDefault::Run [0x01CFE12B+219]
	base::MessageLoop::Run [0x01C8FB0B+107]
	base::RunLoop::Run [0x01C84D53+147]
	base::Thread::Run [0x01CC5C5D+173]
	base::Thread::ThreadMain [0x01CC676E+622]
	base::PlatformThread::Sleep [0x01C8B762+290]
	BaseThreadInitThunk [0x75E17C04+36]
	RtlInitializeExceptionChain [0x7798AB8F+143]
	RtlInitializeExceptionChain [0x7798AB5A+90]

Original issue's description:
> Add support for I444 in VideoFrameBuffer
> 
> VideoFrameBuffer is currently hard coded to be either I420 or Native.
> This CL makes VideoFrameBuffer more generic by moving the I420 specific
> functions into their own class, and adds an enum tag that represents the
> format and storage type of the buffer. Each buffer type is then
> represented as a subclass. See webrtc/api/video/video_frame_buffer.h for
> more info.
> 
> This CL also adds support for representing I444 in VideoFrameBuffer
> using the new interface. Possible future buffer type candidates are
> RGB and NV12.
> 
> BUG=webrtc:7632
> TBR=stefan@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2847383002
> Cr-Commit-Position: refs/heads/master@{#18098}
> Committed: https://chromium.googlesource.com/external/webrtc/+/712338eed24a8d68699b331acad12edf340ac929

TBR=nisse@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7632

[guidou, 2017-06-08 08:28:31]

The CQ bit was checked by guidou@webrtc.org

[guidou, 2017-06-08 08:28:31]

Created Revert of Add support for multiple pixel formats in VideoFrameBuffer

[commit-bot: I haz the power, 2017-06-08 08:28:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-08 08:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 08:30:06]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/26333)
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17898)

[guidou, 2017-06-08 08:31:36]

Description was changed from

==========
Revert of Add support for multiple pixel formats in VideoFrameBuffer (patchset
#7 id:320001 of https://codereview.webrtc.org/2847383002/ )

Reason for revert:
Suspect of breaking FYI bots.
See
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win8%20Tester/build...

[4100:4488:0607/163040.910:9150875:FATAL:webrtc_video_frame_adapter.cc(98)]
Check failed: false. 
Backtrace:
	base::debug::StackTrace::StackTrace [0x01CD71F7+55]
	base::debug::StackTrace::StackTrace [0x01CF179A+10]
	content::WebRtcVideoFrameAdapter::NativeToI420Buffer [0x03229C01+305]
	webrtc::VideoFrameBuffer::ToI420 [0x012640E7+39]
	webrtc::VP8EncoderImpl::Encode [0x036DAA93+179]
	webrtc::VCMGenericEncoder::Encode [0x036D04B4+333]
	webrtc::vcm::VideoSender::AddVideoFrame [0x036CE35B+796]
	webrtc::ViEEncoder::EncodeVideoFrame [0x036AF2E6+884]
	webrtc::ViEEncoder::EncodeTask::Run [0x036B04C7+215]
	rtc::TaskQueue::PostTask [0x02847B8B+194]
	base::internal::Invoker<base::internal::BindState<void
(__cdecl*)(std::unique_ptr<webcrypto::`anonymous
namespace'::DeriveBitsState,std::default_delete<webcrypto::`anonymous
namespace'::DeriveBitsState>
>),base::internal::PassedWrapper<std::unique_ptr<web [0x01143F3E+31]
	base::internal::Invoker<base::internal::BindState<void
(__cdecl*)(std::unique_ptr<webcrypto::`anonymous
namespace'::DeriveBitsState,std::default_delete<webcrypto::`anonymous
namespace'::DeriveBitsState>
>),base::internal::PassedWrapper<std::unique_ptr<web [0x01148086+22]
	base::debug::TaskAnnotator::RunTask [0x01CFD279+409]
	base::MessageLoop::RunTask [0x01C8FFF1+1233]
	base::MessageLoop::DoWork [0x01C8F3AD+765]
	base::MessagePumpDefault::Run [0x01CFE12B+219]
	base::MessageLoop::Run [0x01C8FB0B+107]
	base::RunLoop::Run [0x01C84D53+147]
	base::Thread::Run [0x01CC5C5D+173]
	base::Thread::ThreadMain [0x01CC676E+622]
	base::PlatformThread::Sleep [0x01C8B762+290]
	BaseThreadInitThunk [0x75E17C04+36]
	RtlInitializeExceptionChain [0x7798AB8F+143]
	RtlInitializeExceptionChain [0x7798AB5A+90]

Original issue's description:
> Add support for I444 in VideoFrameBuffer
> 
> VideoFrameBuffer is currently hard coded to be either I420 or Native.
> This CL makes VideoFrameBuffer more generic by moving the I420 specific
> functions into their own class, and adds an enum tag that represents the
> format and storage type of the buffer. Each buffer type is then
> represented as a subclass. See webrtc/api/video/video_frame_buffer.h for
> more info.
> 
> This CL also adds support for representing I444 in VideoFrameBuffer
> using the new interface. Possible future buffer type candidates are
> RGB and NV12.
> 
> BUG=webrtc:7632
> TBR=stefan@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2847383002
> Cr-Commit-Position: refs/heads/master@{#18098}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/712338eed24a8d68699b331ac...

TBR=nisse@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7632
==========

to

==========
Revert of Add support for multiple pixel formats in VideoFrameBuffer (patchset
#7 id:320001 of https://codereview.webrtc.org/2847383002/ )

Reason for revert:
Suspect of breaking FYI bots.
See
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win8%20Tester/build...

[4100:4488:0607/163040.910:9150875:FATAL:webrtc_video_frame_adapter.cc(98)]
Check failed: false. 
Backtrace:
	base::debug::StackTrace::StackTrace [0x01CD71F7+55]
	base::debug::StackTrace::StackTrace [0x01CF179A+10]
	content::WebRtcVideoFrameAdapter::NativeToI420Buffer [0x03229C01+305]
	webrtc::VideoFrameBuffer::ToI420 [0x012640E7+39]
	webrtc::VP8EncoderImpl::Encode [0x036DAA93+179]
	webrtc::VCMGenericEncoder::Encode [0x036D04B4+333]
	webrtc::vcm::VideoSender::AddVideoFrame [0x036CE35B+796]
	webrtc::ViEEncoder::EncodeVideoFrame [0x036AF2E6+884]
	webrtc::ViEEncoder::EncodeTask::Run [0x036B04C7+215]
	rtc::TaskQueue::PostTask [0x02847B8B+194]
	base::internal::Invoker<base::internal::BindState<void
(__cdecl*)(std::unique_ptr<webcrypto::`anonymous
namespace'::DeriveBitsState,std::default_delete<webcrypto::`anonymous
namespace'::DeriveBitsState>
>),base::internal::PassedWrapper<std::unique_ptr<web [0x01143F3E+31]
	base::internal::Invoker<base::internal::BindState<void
(__cdecl*)(std::unique_ptr<webcrypto::`anonymous
namespace'::DeriveBitsState,std::default_delete<webcrypto::`anonymous
namespace'::DeriveBitsState>
>),base::internal::PassedWrapper<std::unique_ptr<web [0x01148086+22]
	base::debug::TaskAnnotator::RunTask [0x01CFD279+409]
	base::MessageLoop::RunTask [0x01C8FFF1+1233]
	base::MessageLoop::DoWork [0x01C8F3AD+765]
	base::MessagePumpDefault::Run [0x01CFE12B+219]
	base::MessageLoop::Run [0x01C8FB0B+107]
	base::RunLoop::Run [0x01C84D53+147]
	base::Thread::Run [0x01CC5C5D+173]
	base::Thread::ThreadMain [0x01CC676E+622]
	base::PlatformThread::Sleep [0x01C8B762+290]
	BaseThreadInitThunk [0x75E17C04+36]
	RtlInitializeExceptionChain [0x7798AB8F+143]
	RtlInitializeExceptionChain [0x7798AB5A+90]

Original issue's description:
> Add support for I444 in VideoFrameBuffer
> 
> VideoFrameBuffer is currently hard coded to be either I420 or Native.
> This CL makes VideoFrameBuffer more generic by moving the I420 specific
> functions into their own class, and adds an enum tag that represents the
> format and storage type of the buffer. Each buffer type is then
> represented as a subclass. See webrtc/api/video/video_frame_buffer.h for
> more info.
> 
> This CL also adds support for representing I444 in VideoFrameBuffer
> using the new interface. Possible future buffer type candidates are
> RGB and NV12.
> 
> BUG=webrtc:7632
> TBR=stefan@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2847383002
> Cr-Commit-Position: refs/heads/master@{#18098}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/712338eed24a8d68699b331ac...

TBR=nisse@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7632
==========

[guidou, 2017-06-08 08:31:52]

Closing, since this was the wrong revert.