Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 2924243003: Remove default implementation of PeerConnectionInterface::SetBitrate. (Closed)

Created:
3 years, 6 months ago by Zach Stein
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove default implementation of PeerConnectionInterface::SetBitrate. This was included to avoid breaking chromium, which now includes its own implementation (https://chromium.googlesource.com/chromium/src/+/725cb26dab3bae1cbb3339ed13186848f608cfad). BUG=webrtc:7395 Review-Url: https://codereview.webrtc.org/2924243003 Cr-Commit-Position: refs/heads/master@{#19063} Committed: https://chromium.googlesource.com/external/webrtc/+/83dc6b6f5380d7c03f5ebfe2553bf4a3147e2d1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Zach Stein
3 years, 6 months ago (2017-06-08 20:29:48 UTC) #2
Taylor Brandstetter
lgtm
3 years, 6 months ago (2017-06-09 02:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2924243003/1
3 years, 6 months ago (2017-06-09 02:45:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/builds/6260)
3 years, 6 months ago (2017-06-09 02:47:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2924243003/1
3 years, 5 months ago (2017-07-17 22:06:26 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 22:09:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/83dc6b6f5380d7c03f5ebfe25...

Powered by Google App Engine
This is Rietveld 408576698