Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2924093002: Revert of Refactored incoming bitrate estimator. (Closed)

Created:
3 years, 6 months ago by tschumim
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactored incoming bitrate estimator. (patchset #8 id:140001 of https://codereview.webrtc.org/2917873002/ ) Reason for revert: Caused failure in vice test Original issue's description: > Refactored incoming bitrate estimator. > > BUG=webrtc:7746 > > Review-Url: https://codereview.webrtc.org/2917873002 > Cr-Commit-Position: refs/heads/master@{#18478} > Committed: https://chromium.googlesource.com/external/webrtc/+/5fc8bf8b87495c225f5060760fa9d967b8dc9f9e TBR=philipel@webrtc.org,terelius@webrtc.org,stefan@webrtc.org,tschumim@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -240 lines) Patch
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 3 chunks +23 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 8 chunks +113 lines, -12 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 5 chunks +3 lines, -31 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tschumim
Created Revert of Refactored incoming bitrate estimator.
3 years, 6 months ago (2017-06-07 18:48:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2924093002/1
3 years, 6 months ago (2017-06-07 18:48:47 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 18:48:49 UTC) #5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698