Add field trial for balanced degradation preference.

Add field trial for balanced degradation preference.

BUG=webrtc:7607
Review-Url: https://codereview.webrtc.org/2923563002
Cr-Commit-Position: refs/heads/master@{#18589}
Committed: https://chromium.googlesource.com/external/webrtc/+/3c81a1afd87a1764a6515fca365b8723828a089f

[åsapersson, 2017-06-13 09:05:16]

Description was changed from

==========
Add field trial for balanced degradation preference.

BUG=webrtc:7607
==========

to

==========
Add field trial for balanced degradation preference.

BUG=webrtc:7607
==========

[åsapersson, 2017-06-13 09:05:16]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman1, 2017-06-13 09:23:18]

mflodman@google.com changed reviewers:
+ mflodman@google.com

[mflodman1, 2017-06-13 09:23:19]

One comment, LGTM with that addressed.

https://codereview.webrtc.org/2923563002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/2923563002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2.cc:1754: if
(webrtc::field_trial::IsEnabled("WebRTC-Video-BalancedDegradation"))
WDYT of, to avoid more nested if statements:

if (parameters_.options.is_screencast.value_or(false)) {
  degradation_preference = DegradationPreference::kMaintainResolution;
} else if (webrtc::field_trial::IsEnabled("WebRTC-Video-BalancedDegradation")) {
  degradation_preference = DegradationPreference::kBalanced;
} else {
  degradation_preference = DegradationPreference::kMaintainFramerate;
}

[åsapersson, 2017-06-13 10:17:16]

https://codereview.webrtc.org/2923563002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/2923563002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2.cc:1754: if
(webrtc::field_trial::IsEnabled("WebRTC-Video-BalancedDegradation"))
On 2017/06/13 09:23:19, mflodman1 wrote:
> WDYT of, to avoid more nested if statements:
> 
> if (parameters_.options.is_screencast.value_or(false)) {
>   degradation_preference = DegradationPreference::kMaintainResolution;
> } else if (webrtc::field_trial::IsEnabled("WebRTC-Video-BalancedDegradation"))
{
>   degradation_preference = DegradationPreference::kBalanced;
> } else {
>   degradation_preference = DegradationPreference::kMaintainFramerate;
> }

Done.

[mflodman, 2017-06-13 11:18:55]

LGTM

[åsapersson, 2017-06-14 12:00:42]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-06-14 12:00:44]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@google.com,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2923563002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2017-06-14 12:00:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-14 12:52:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497441642564270,
"parent_rev": "c417d9e558eb784a6933cfbd555cd7c3cab36bf8", "commit_rev":
"3c81a1afd87a1764a6515fca365b8723828a089f"}

[commit-bot: I haz the power, 2017-06-14 12:52:31]

Description was changed from

==========
Add field trial for balanced degradation preference.

BUG=webrtc:7607
==========

to

==========
Add field trial for balanced degradation preference.

BUG=webrtc:7607

Review-Url: https://codereview.webrtc.org/2923563002
Cr-Commit-Position: refs/heads/master@{#18589}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3c81a1afd87a1764a6515fca3...
==========

[commit-bot: I haz the power, 2017-06-14 12:52:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/3c81a1afd87a1764a6515fca3...