Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2923163006: Delete rtc_event_log/ringbuffer.h (Closed)

Created:
3 years, 6 months ago by terelius
Modified:
3 years, 6 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete rtc_event_log/ringbuffer.h This code is unused since https://codereview.webrtc.org/2875823003/ and the current implementation is too specific to the event log to be useful elsewhere. I think we should get add a reusable cyclic buffer though and I made a rough draft of what it might look like: https://codereview.webrtc.org/2691073002/ BUG=webrtc:7732 Review-Url: https://codereview.webrtc.org/2923163006 Cr-Commit-Position: refs/heads/master@{#18465} Committed: https://chromium.googlesource.com/external/webrtc/+/f53c4cd8674f3719799aaf0c926d8d23985b89b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -273 lines) Patch
M webrtc/logging/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/logging/rtc_event_log/ringbuffer.h View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/logging/rtc_event_log/ringbuffer_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
terelius
3 years, 6 months ago (2017-06-07 07:53:20 UTC) #4
nisse-webrtc
lgtm.
3 years, 6 months ago (2017-06-07 08:50:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2923163006/1
3 years, 6 months ago (2017-06-07 08:51:20 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 08:53:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f53c4cd8674f3719799aaf0c9...

Powered by Google App Engine
This is Rietveld 408576698