Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2921463005: Change all numerical string inputs to int and remove unused stderr (Closed)

Created:
3 years, 6 months ago by janssonWebRTC
Modified:
3 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change all numerical string inputs to int and remove unused stderr BUG=webrtc:7757 NOTRY=True Review-Url: https://codereview.webrtc.org/2921463005 Cr-Commit-Position: refs/heads/master@{#18403} Committed: https://chromium.googlesource.com/external/webrtc/+/9b93203c8fd81a3538a2ad0d4802be6fec0408a6

Patch Set 1 #

Patch Set 2 : remove unecessary print #

Total comments: 1

Patch Set 3 : change float to int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M webrtc/tools/video_analysis.py View 1 2 6 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
janssonWebRTC
3 years, 6 months ago (2017-06-02 07:58:12 UTC) #2
kjellander_webrtc
lgtm with comment addressed I added NOTRY=True for you. https://codereview.webrtc.org/2921463005/diff/20001/webrtc/tools/video_analysis.py File webrtc/tools/video_analysis.py (right): https://codereview.webrtc.org/2921463005/diff/20001/webrtc/tools/video_analysis.py#newcode54 webrtc/tools/video_analysis.py:54: ...
3 years, 6 months ago (2017-06-02 08:51:01 UTC) #4
janssonWebRTC
On 2017/06/02 08:51:01, kjellander_webrtc wrote: > lgtm with comment addressed > > I added NOTRY=True ...
3 years, 6 months ago (2017-06-02 09:12:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2921463005/40001
3 years, 6 months ago (2017-06-02 09:14:18 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 09:16:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/9b93203c8fd81a3538a2ad0d4...

Powered by Google App Engine
This is Rietveld 408576698