Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2921223002: [CSS Typed OM] Hook up getting CSSUnitValues from inline StylePropertyMaps (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
Reviewers:
Eric Willigers
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Hook up getting CSSUnitValues from inline StylePropertyMaps Also re-enables support for Lengths and Percentages in properties left, top, right, bottom, width, height to match the tests. BUG=545318 Review-Url: https://codereview.chromium.org/2921223002 Cr-Commit-Position: refs/heads/master@{#477239} Committed: https://chromium.googlesource.com/chromium/src/+/5f917947505fc4acadefa5eae4fd8c0249ad5d84

Patch Set 1 #

Patch Set 2 : Fix missed LayoutTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -687 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/computedstyle/border-top-width-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/computedstyle/left-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/computedstyle/width-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-bottom-width-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-left-width-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-right-width-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-top-width-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/bottom-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/height-expected.txt View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/left-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/right-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/top-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/width-expected.txt View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 6 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
meade_UTC10
3 years, 6 months ago (2017-06-05 06:09:08 UTC) #5
Eric Willigers
lgtm
3 years, 6 months ago (2017-06-05 06:16:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921223002/1
3 years, 6 months ago (2017-06-05 06:21:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/471408)
3 years, 6 months ago (2017-06-05 08:16:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921223002/20001
3 years, 6 months ago (2017-06-06 07:21:14 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 09:03:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f917947505fc4acadefa5eae4fd...

Powered by Google App Engine
This is Rietveld 408576698