Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Issue 2921223002: [CSS Typed OM] Hook up getting CSSUnitValues from inline StylePropertyMaps (Closed)
Patch Set: Fix missed LayoutTests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp b/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
index 2fd1ac86528c055de16b32a7c2812c320255d1dc..19074952b95df9e307a1e31dbc82998f929275d9 100644
--- a/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
@@ -7,6 +7,7 @@
#include "core/css/CSSImageValue.h"
#include "core/css/CSSValue.h"
#include "core/css/cssom/CSSKeywordValue.h"
+#include "core/css/cssom/CSSNumericValue.h"
#include "core/css/cssom/CSSOMTypes.h"
#include "core/css/cssom/CSSStyleValue.h"
#include "core/css/cssom/CSSStyleVariableReferenceValue.h"
@@ -19,11 +20,6 @@ namespace blink {
namespace {
-CSSStyleValue* CreateStyleValueFromPrimitiveValue(
- const CSSPrimitiveValue& primitive_value) {
- return nullptr;
-}
-
CSSStyleValue* CreateStyleValueWithPropertyInternal(CSSPropertyID property_id,
const CSSValue& value) {
switch (property_id) {
@@ -41,7 +37,7 @@ CSSStyleValue* CreateStyleValue(const CSSValue& value) {
value.IsCustomIdentValue())
return CSSKeywordValue::FromCSSValue(value);
if (value.IsPrimitiveValue())
- return CreateStyleValueFromPrimitiveValue(ToCSSPrimitiveValue(value));
+ return CSSNumericValue::FromCSSValue(ToCSSPrimitiveValue(value));
if (value.IsVariableReferenceValue())
return CSSUnparsedValue::FromCSSValue(ToCSSVariableReferenceValue(value));
if (value.IsImageValue()) {
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698