Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2919783002:
iOS: Update device testing configuration (Closed)
|
Created:
3 years, 6 months ago by kjellander_webrtc Modified:
3 years, 6 months ago Reviewers:
smut CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptioniOS: Update device testing configuration
The previous configuration committed in
https://codereview.webrtc.org/2903843002/
accidentally was tailored for running on simulator
swarming testers rather than device testers.
BUG=chromium:704912
NOTRY=True
TBR=smut@google.com
Review-Url: https://codereview.webrtc.org/2919783002
Cr-Commit-Position: refs/heads/master@{#18397}
Committed: https://chromium.googlesource.com/external/webrtc/+/62cbb23aeecd48480a7c0aaceb0078453b84ea95
Patch Set 1 #
Total comments: 2
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kjellander@webrtc.org changed reviewers: + smut@google.com
Sana, is this sufficient to make these bots start using iOS swarming devices instead of simulators, which was a mistake by Edward? Or do we need to do changes on the recipe side as well? Ignore the trybot results, I'm having issues getting the internal tryserver to pick up jobs (https://bugs.chromium.org/p/chromium/issues/detail?id=725910)
On 2017/06/01 14:33:50, kjellander_webrtc wrote: > Sana, is this sufficient to make these bots start using iOS swarming devices > instead of simulators, which was a mistake by Edward? > Or do we need to do changes on the recipe side as well? It looks like your recipe (webrtc_internal/standalone) is trying to do local testing. You should call api.bling.test() to trigger your tests on the internal Swarming server that actually has these devices.
On 2017/06/01 22:37:16, smut wrote: > On 2017/06/01 14:33:50, kjellander_webrtc wrote: > > Sana, is this sufficient to make these bots start using iOS swarming devices > > instead of simulators, which was a mistake by Edward? > > Or do we need to do changes on the recipe side as well? > > It looks like your recipe (webrtc_internal/standalone) is trying to do local > testing. You should call api.bling.test() to trigger your tests on the internal > Swarming server that actually has these devices. You must be looking at a version before https://chrome-internal-review.googlesource.com/c/381208/ since it was renamed to webrtc_internal/ios.py in there, and it also uses api.bling.test() now.
Description was changed from ========== iOS: Update device testing configuration The previous configuration committed in https://codereview.webrtc.org/2903843002/ accidentally was tailored for running on simulator swarming testers rather than device testers. BUG=chromium:704912 NOTRY=True ========== to ========== iOS: Update device testing configuration The previous configuration committed in https://codereview.webrtc.org/2903843002/ accidentally was tailored for running on simulator swarming testers rather than device testers. BUG=chromium:704912 NOTRY=True TBR=smut@google.com ==========
On 2017/06/02 06:12:22, kjellander_webrtc wrote: > On 2017/06/01 22:37:16, smut wrote: > > On 2017/06/01 14:33:50, kjellander_webrtc wrote: > > > Sana, is this sufficient to make these bots start using iOS swarming devices > > > instead of simulators, which was a mistake by Edward? > > > Or do we need to do changes on the recipe side as well? > > > > It looks like your recipe (webrtc_internal/standalone) is trying to do local > > testing. You should call api.bling.test() to trigger your tests on the > internal > > Swarming server that actually has these devices. > > You must be looking at a version before > https://chrome-internal-review.googlesource.com/c/381208/ since it was renamed > to webrtc_internal/ios.py in there, and it also uses api.bling.test() now. I'll commit this now to try it out. We don't have any coverage as it is now so I'd like to move forward today.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496384017332530, "parent_rev":
"daf9a711856c7c04c73aa7188f64c249bd5a17f0", "commit_rev":
"62cbb23aeecd48480a7c0aaceb0078453b84ea95"}
Message was sent while issue was closed.
Description was changed from ========== iOS: Update device testing configuration The previous configuration committed in https://codereview.webrtc.org/2903843002/ accidentally was tailored for running on simulator swarming testers rather than device testers. BUG=chromium:704912 NOTRY=True TBR=smut@google.com ========== to ========== iOS: Update device testing configuration The previous configuration committed in https://codereview.webrtc.org/2903843002/ accidentally was tailored for running on simulator swarming testers rather than device testers. BUG=chromium:704912 NOTRY=True TBR=smut@google.com Review-Url: https://codereview.webrtc.org/2919783002 Cr-Commit-Position: refs/heads/master@{#18397} Committed: https://chromium.googlesource.com/external/webrtc/+/62cbb23aeecd48480a7c0aace... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/62cbb23aeecd48480a7c0aace...
Message was sent while issue was closed.
Apparently my draft comment didn't publish. https://codereview.webrtc.org/2919783002/diff/1/tools_webrtc/ios/internal.cli... File tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json (right): https://codereview.webrtc.org/2919783002/diff/1/tools_webrtc/ios/internal.cli... tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json:21: "bucket": "bling-archive", You could use your chromium-webrtc bucket here too.
Message was sent while issue was closed.
https://codereview.webrtc.org/2919783002/diff/1/tools_webrtc/ios/internal.cli... File tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json (right): https://codereview.webrtc.org/2919783002/diff/1/tools_webrtc/ios/internal.cli... tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json:21: "bucket": "bling-archive", On 2017/06/02 22:34:42, smut wrote: > You could use your chromium-webrtc bucket here too. Ah, sorry. I missed this. Will make a follow-up CL. Didn't mean to pollute your bucket. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
