Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2919693004: Remove additional_target_cpus = [ "arm" ] from iOS device build configs (Closed)

Created:
3 years, 6 months ago by kjellander_webrtc
Modified:
3 years, 6 months ago
Reviewers:
smut
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove additional_target_cpus = [ "arm" ] from iOS device build configs The configs committed in https://codereview.webrtc.org/2919783002/ was not passing GN and we're still unable to use trybots to test them due to crbug.com/725910. BUG=chromium:704912 NOTRY=True TBR=smut@google.com Review-Url: https://codereview.webrtc.org/2919693004 Cr-Commit-Position: refs/heads/master@{#18398} Committed: https://chromium.googlesource.com/external/webrtc/+/cbd3ee3e7793b600059f724b7a30b79b20ec56fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools_webrtc/ios/internal.tryserver.webrtc/ios_arm64.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2919693004/1
3 years, 6 months ago (2017-06-02 07:21:34 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 07:23:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cbd3ee3e7793b600059f724b7...

Powered by Google App Engine
This is Rietveld 408576698