Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2919483002: Use oneof in event log proto to reduce memory consumption. (Closed)

Created:
3 years, 6 months ago by terelius
Modified:
3 years, 6 months ago
Reviewers:
ivoc, kolmodin1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use oneof in event log proto to reduce memory consumption. BUG=webrtc:7732 Review-Url: https://codereview.webrtc.org/2919483002 Cr-Commit-Position: refs/heads/master@{#18350} Committed: https://chromium.googlesource.com/external/webrtc/+/8b2b9efab68a55beb7112a60bdb80bcb8425f2e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 1 chunk +26 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
terelius
3 years, 6 months ago (2017-05-31 10:47:24 UTC) #6
ivoc
lgtm!
3 years, 6 months ago (2017-05-31 11:50:47 UTC) #7
kolmodin1
lgtm lgtm!
3 years, 6 months ago (2017-05-31 12:17:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2919483002/1
3 years, 6 months ago (2017-05-31 12:44:06 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 12:46:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8b2b9efab68a55beb7112a60b...

Powered by Google App Engine
This is Rietveld 408576698