Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: webrtc/BUILD.gn

Issue 2918803002: enabling `gn check` on the whole WebRTC repo (Closed)
Patch Set: removing TODO Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | webrtc/pc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index f8e0e8de15ee49cf10059cc0aa4fde27086d8210..1a79a12db22afe2365fbb31e95bc55c0fae5d05f 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -229,6 +229,12 @@ rtc_source_set("video_stream_api") {
"video_receive_stream.h",
"video_send_stream.h",
]
+ deps = [
+ ":webrtc_common",
+ "api:transport_api",
+ "base:rtc_base_approved",
+ "common_video:common_video",
+ ]
}
# Contents of video_frame.h is moved from top-level down to common_video/.
@@ -349,6 +355,13 @@ if (!build_with_chromium) {
}
rtc_static_library("webrtc_common") {
+ # TODO(mbonadei): Remove (bugs.webrtc.org/7745)
+ # Enabling GN check triggers cyclic dependency error:
+ # //webrtc:webrtc_common ->
+ # //webrtc/api:video_frame_api ->
+ # //webrtc/system_wrappers:system_wrappers ->
+ # //webrtc:webrtc_common
+ check_includes = false
sources = [
"common_types.cc",
"common_types.h",
@@ -361,6 +374,9 @@ rtc_static_library("webrtc_common") {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
+ deps = [
+ "base:rtc_base_approved",
+ ]
}
if (use_libfuzzer || use_drfuzz || use_afl) {
« no previous file with comments | « .gn ('k') | webrtc/pc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698