Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: .gn

Issue 2918803002: enabling `gn check` on the whole WebRTC repo (Closed)
Patch Set: removing TODO Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index 70a0c3e45ed5924e736539177743a44621734329..4046d94b07843d14b2f76a8fc442404fe2c53214 100644
--- a/.gn
+++ b/.gn
@@ -20,28 +20,7 @@ secondary_source = "//build/secondary/"
# matching these patterns (see "gn help label_pattern" for format) will have
# their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check".
-# TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is done.
-check_targets = [
- "//webrtc/api/*",
- "//webrtc/audio/*",
- "//webrtc/base/*",
- "//webrtc/call/*",
- "//webrtc/common_video/*",
- "//webrtc/common_audio/*",
- "//webrtc/examples/*",
- "//webrtc/logging/*",
- "//webrtc/media/*",
- "//webrtc/modules/*",
- "//webrtc/ortc/*",
- "//webrtc/p2p/*",
- "//webrtc/sdk/*",
- "//webrtc/stats/*",
- "//webrtc/system_wrappers/*",
- "//webrtc/test/*",
- "//webrtc/tools/*",
- "//webrtc/video/*",
- "//webrtc/voice_engine/*",
-]
+check_targets = [ "//webrtc/*" ]
# These are the list of GN files that run exec_script. This whitelist exists
# to force additional review for new uses of exec_script, which is strongly
« no previous file with comments | « no previous file | webrtc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698