Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2916793003: Revert of Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (Closed)

Created:
3 years, 6 months ago by charujain
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (patchset #8 id:140001 of https://codereview.webrtc.org/2863123002/ ) Reason for revert: Broken downstream projects Original issue's description: > Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. > > Prior to this CL Call::Stats were collected via WebRtcVideoEngine2, but not via WebRtcVoiceEngine, causing these stats to be missing for audio-only calls. Call lives on the peerconnection/session level and should only be collected once independent on how many streams we have. > > BUG=webrtc:5079 > R=deadbeef@webrtc.org, hbos@webrtc.org > > Review-Url: https://codereview.webrtc.org/2863123002 . > Cr-Commit-Position: refs/heads/master@{#18384} > Committed: https://chromium.googlesource.com/external/webrtc/+/e80f4c91d0a2854a339e419162fdcd1d916f7de0 TBR=hbos@webrtc.org,deadbeef@webrtc.org,holmer@google.com,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5079 Review-Url: https://codereview.webrtc.org/2916793003 Cr-Commit-Position: refs/heads/master@{#18386} Committed: https://chromium.googlesource.com/external/webrtc/+/d72098a41971833e210bfdcffaab7a18ced4775f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -167 lines) Patch
M webrtc/media/base/fakemediaengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/base/mediachannel.h View 2 chunks +2 lines, -9 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 3 chunks +14 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/pc/channel.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/pc/channel.cc View 12 chunks +33 lines, -43 lines 0 comments Download
M webrtc/pc/rtcstatscollector.h View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 4 chunks +21 lines, -24 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M webrtc/pc/statscollector.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/statscollector.cc View 4 chunks +9 lines, -23 lines 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M webrtc/pc/test/mock_webrtcsession.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/webrtcsession.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/pc/webrtcsession.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
charujain
3 years, 6 months ago (2017-06-01 15:54:34 UTC) #2
Created Revert of Wire up BWE stats through WebrtcSession so that they are
filled in both for audio and video calls.

Powered by Google App Engine
This is Rietveld 408576698