Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2916583005: Ensure the openGLContext is current before trying to reshape the viewport (Closed)

Created:
3 years, 6 months ago by afedor
Modified:
3 years, 6 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensure the openGLContext is current before trying to reshape the viewport Make sure to call ensureGLContext before calling OpenGL functions BUG=webrtc:7751 Review-Url: https://codereview.webrtc.org/2916583005 Cr-Commit-Position: refs/heads/master@{#18511} Committed: https://chromium.googlesource.com/external/webrtc/+/fee994c36717b304731d475ac7eb48b98e8a34e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/sdk/objc/Framework/Classes/UI/RTCNSGLVideoView.m View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
afedor
3 years, 6 months ago (2017-06-02 02:39:15 UTC) #3
magjed_webrtc
lgtm
3 years, 6 months ago (2017-06-02 09:27:59 UTC) #4
afedor
On 2017/06/02 09:27:59, magjed_webrtc wrote: > lgtm Thanks. I don't have commit privileges, so someone ...
3 years, 6 months ago (2017-06-04 02:33:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2916583005/1
3 years, 6 months ago (2017-06-09 11:51:39 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 12:16:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fee994c36717b304731d475ac...

Powered by Google App Engine
This is Rietveld 408576698