Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2916513002: Delete webrtc/call.h (replaced with webrtc/call/call.h). (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete webrtc/call.h (replaced with webrtc/call/call.h). BUG=webrtc:6716 Review-Url: https://codereview.webrtc.org/2916513002 Cr-Commit-Position: refs/heads/master@{#18491} Committed: https://chromium.googlesource.com/external/webrtc/+/75b68b924c803c7ec94cfebce9c42096e3efed68

Patch Set 1 #

Patch Set 2 : Drop webrtc/call.h also from webrtc/src/webrtc/DEPS. #

Patch Set 3 : Rebase. #

Patch Set 4 : Drop call.h from webrtc:webrtc sources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/BUILD.gn View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/DEPS View 1 2 chunks +0 lines, -7 lines 0 comments Download
D webrtc/call.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
nisse-webrtc
PTAL: I suspect there's one or two uses left in internal projects, but I think ...
3 years, 6 months ago (2017-05-31 06:57:25 UTC) #2
kwiberg-webrtc
On 2017/05/31 06:57:25, nisse-webrtc wrote: > PTAL: I suspect there's one or two uses left ...
3 years, 6 months ago (2017-05-31 08:03:35 UTC) #4
nisse-webrtc
On 2017/05/31 08:03:35, kwiberg-webrtc wrote: > On 2017/05/31 06:57:25, nisse-webrtc wrote: > > PTAL: I ...
3 years, 6 months ago (2017-05-31 08:12:14 UTC) #6
ossu
On 2017/05/31 08:12:14, nisse-webrtc wrote: > On 2017/05/31 08:03:35, kwiberg-webrtc wrote: > > On 2017/05/31 ...
3 years, 6 months ago (2017-05-31 09:09:56 UTC) #7
kwiberg-webrtc
On 2017/05/31 09:09:56, ossu wrote: > On 2017/05/31 08:12:14, nisse-webrtc wrote: > > On 2017/05/31 ...
3 years, 6 months ago (2017-05-31 10:35:11 UTC) #8
ossu
On 2017/05/31 09:09:56, ossu wrote: > On 2017/05/31 08:12:14, nisse-webrtc wrote: > > On 2017/05/31 ...
3 years, 6 months ago (2017-05-31 10:42:51 UTC) #9
nisse-webrtc
On 2017/05/31 10:42:51, ossu wrote: > On 2017/05/31 09:09:56, ossu wrote: > > On 2017/05/31 ...
3 years, 6 months ago (2017-05-31 11:28:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2916513002/1
3 years, 6 months ago (2017-06-08 07:15:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/4966) ios_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 6 months ago (2017-06-08 07:16:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2916513002/60001
3 years, 6 months ago (2017-06-08 08:59:05 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 09:21:23 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/75b68b924c803c7ec94cfebce...

Powered by Google App Engine
This is Rietveld 408576698