Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2915903003: Delete unneeded includes of system_wrappers/include/sleep.h (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, AleBzk, peah-webrtc, henrika_webrtc, aleloi, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, minyue-webrtc, the sun, yujie_mao (webrtc), mflodman, zhengzhonghou_agora.io, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unneeded includes of system_wrappers/include/sleep.h BUG=None Review-Url: https://codereview.webrtc.org/2915903003 Cr-Commit-Position: refs/heads/master@{#18380} Committed: https://chromium.googlesource.com/external/webrtc/+/7926c129331f5530e84da6061a115bbdc7ea438a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M webrtc/modules/audio_coding/test/target_delay_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_performance_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
nisse-webrtc
PTAL. Not sure what we should do about system_wrappers' sleep.h. Move to webrtc/base, or should ...
3 years, 6 months ago (2017-06-01 11:46:09 UTC) #2
nisse-webrtc
On 2017/06/01 11:46:09, nisse-webrtc wrote: > PTAL. Not sure what we should do about system_wrappers' ...
3 years, 6 months ago (2017-06-01 11:50:27 UTC) #3
kwiberg-webrtc
lgtm
3 years, 6 months ago (2017-06-01 12:11:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2915903003/1
3 years, 6 months ago (2017-06-01 12:12:03 UTC) #6
kwiberg-webrtc
On 2017/06/01 11:46:09, nisse-webrtc wrote: > PTAL. Not sure what we should do about system_wrappers' ...
3 years, 6 months ago (2017-06-01 12:12:36 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 12:34:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7926c129331f5530e84da6061...

Powered by Google App Engine
This is Rietveld 408576698