Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2915263002: Revert "Revert of Wire up BWE stats through WebrtcSession so that they are filled in both for audio… (Closed)

Created:
3 years, 6 months ago by stefan-webrtc
Modified:
3 years, 6 months ago
Reviewers:
holmer, hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, noahric-google
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Revert of Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (patchset #8 id:140001 of https://codereview.webrtc.org/2863123002/ )" This reverts commit d72098a41971833e210bfdcffaab7a18ced4775f. BUG=webrtc:5079 Review-Url: https://codereview.webrtc.org/2915263002 Cr-Commit-Position: refs/heads/master@{#18411} Committed: https://chromium.googlesource.com/external/webrtc/+/f79ade1320d1f27dc85a1bf7da5ca430ca80ab85

Patch Set 1 #

Patch Set 2 : Re-add bw_estimations. #

Patch Set 3 : Really fix the problem... #

Patch Set 4 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -105 lines) Patch
M webrtc/media/base/fakemediaengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 1 2 3 2 chunks +11 lines, -0 lines 2 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/pc/channel.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/pc/channel.cc View 12 chunks +43 lines, -33 lines 0 comments Download
M webrtc/pc/rtcstatscollector.h View 3 chunks +5 lines, -1 line 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 4 chunks +24 lines, -21 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M webrtc/pc/statscollector.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/statscollector.cc View 4 chunks +23 lines, -9 lines 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M webrtc/pc/test/mock_webrtcsession.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/webrtcsession.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/pc/webrtcsession.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
stefan-webrtc
Re-add bw_estimations.
3 years, 6 months ago (2017-06-02 08:02:07 UTC) #1
stefan-webrtc
Had to revert and reland with a small change due to an internal project. Could ...
3 years, 6 months ago (2017-06-02 08:22:37 UTC) #3
stefan-webrtc
.
3 years, 6 months ago (2017-06-02 08:41:54 UTC) #4
hbos
https://codereview.webrtc.org/2915263002/diff/60001/webrtc/media/base/mediachannel.h File webrtc/media/base/mediachannel.h (right): https://codereview.webrtc.org/2915263002/diff/60001/webrtc/media/base/mediachannel.h#newcode873 webrtc/media/base/mediachannel.h:873: std::vector<BandwidthEstimationInfo> bw_estimations; You've still removed filling in the bw_estimations ...
3 years, 6 months ago (2017-06-02 10:37:51 UTC) #5
holmer
3 years, 6 months ago (2017-06-02 11:34:01 UTC) #7
holmer
https://codereview.webrtc.org/2915263002/diff/60001/webrtc/media/base/mediachannel.h File webrtc/media/base/mediachannel.h (right): https://codereview.webrtc.org/2915263002/diff/60001/webrtc/media/base/mediachannel.h#newcode873 webrtc/media/base/mediachannel.h:873: std::vector<BandwidthEstimationInfo> bw_estimations; On 2017/06/02 10:37:51, hbos wrote: > You've ...
3 years, 6 months ago (2017-06-02 11:34:26 UTC) #8
hbos
lgtm
3 years, 6 months ago (2017-06-02 11:35:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2915263002/60001
3 years, 6 months ago (2017-06-02 13:21:44 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 13:44:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/f79ade1320d1f27dc85a1bf7d...

Powered by Google App Engine
This is Rietveld 408576698