Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2914493002: Remove RTPSenderVideo::FecPacketOverhead() since it is unused. (Closed)

Created:
3 years, 6 months ago by brandtr
Modified:
3 years, 6 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RTPSenderVideo::FecPacketOverhead() since it is unused. BUG=None Review-Url: https://codereview.webrtc.org/2914493002 Cr-Commit-Position: refs/heads/master@{#18315} Committed: https://chromium.googlesource.com/external/webrtc/+/53800ed191a16cc44c3f5a00bce7d481a65932cd

Patch Set 1 #

Patch Set 2 : Stop depending on other CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
brandtr
Looks like dead code.
3 years, 6 months ago (2017-05-29 14:36:10 UTC) #3
danilchap
lgtm
3 years, 6 months ago (2017-05-29 14:55:13 UTC) #4
brandtr
Stop depending on other CL.
3 years, 6 months ago (2017-05-29 14:59:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2914493002/40001
3 years, 6 months ago (2017-05-29 15:54:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2914493002/40001
3 years, 6 months ago (2017-05-30 06:31:25 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 06:34:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/53800ed191a16cc44c3f5a00b...

Powered by Google App Engine
This is Rietveld 408576698