Chromium Code Reviews

Issue 2914413002: Revert of Add PeerConnectionInterface::UpdateCallBitrate. (Closed)

Created:
3 years, 6 months ago by charujain
Modified:
3 years, 6 months ago
Reviewers:
holmer, Zach Stein, stefan-webrtc, Taylor Brandstetter, kwiberg-webrtc, the sun
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, mflodman, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add PeerConnectionInterface::UpdateCallBitrate. (patchset #7 id:120001 of https://codereview.webrtc.org/2888303005/ ) Reason for revert: Broken downstream project. Original issue's description: > Adds PeerConnectionInterface::UpdateCallBitrate to give clients more control of the bandwidth estimator. PeerConnection implements this method by passing a BitrateConfigMask to its associated Call, which is combined with the existing BitrateConfig and passed on to the SendSideCongestionController as necessary. The existing BitrateConfig generally comes from the x-google-{min,start,max}-bitrate params in the SDP. > > BUG=webrtc:7395 > > Review-Url: https://codereview.webrtc.org/2888303005 > Cr-Commit-Position: refs/heads/master@{#18417} > Committed: https://chromium.googlesource.com/external/webrtc/+/9641c133277da0d04b78782b32391996607afa80 TBR=deadbeef@webrtc.org,stefan@webrtc.org,kwiberg@webrtc.org,solenberg@webrtc.org,holmer@google.com,zstein@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7395 Review-Url: https://codereview.webrtc.org/2914413002 Cr-Commit-Position: refs/heads/master@{#18420} Committed: https://chromium.googlesource.com/external/webrtc/+/441718ef69db9fef17ee85c197fa5e17a29df55a

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+40 lines, -498 lines)
M webrtc/api/peerconnectioninterface.h View 1 chunk +0 lines, -15 lines 0 comments
M webrtc/api/peerconnectionproxy.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/call/call.h View 3 chunks +6 lines, -26 lines 0 comments
M webrtc/call/call.cc View 5 chunks +23 lines, -105 lines 0 comments
M webrtc/call/call_unittest.cc View 4 chunks +11 lines, -231 lines 0 comments
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +0 lines, -5 lines 0 comments
M webrtc/pc/peerconnection.h View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/pc/peerconnection.cc View 1 chunk +0 lines, -48 lines 0 comments
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments

Messages

Total messages: 6 (3 generated)
charujain
Created Revert of Add PeerConnectionInterface::UpdateCallBitrate.
3 years, 6 months ago (2017-06-02 19:31:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2914413002/1
3 years, 6 months ago (2017-06-02 19:31:19 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:31:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/441718ef69db9fef17ee85c19...

Powered by Google App Engine