MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9 and turn on quality scaling.

MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9 and turn on quality scaling.
 
Add default QP scaling thresholds for VP9.
 
BUG=webrtc:7662
Review-Url: https://codereview.webrtc.org/2914363002
Cr-Commit-Position: refs/heads/master@{#18469}
Committed: https://chromium.googlesource.com/external/webrtc/+/1e15a994ac668d37d8b2d7bbcf4864635e3fb3f3

[åsapersson, 2017-06-05 12:05:21]

Patchset #2 (id:20001) has been deleted

[åsapersson, 2017-06-05 12:05:34]

Patchset #1 (id:1) has been deleted

[åsapersson, 2017-06-05 12:46:00]

Description was changed from

==========
Wire up qp..

BUG=
==========

to

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9.
 
Add default QP scaling threshold for VP9.
 
BUG=webrtc:7662
==========

[åsapersson, 2017-06-05 12:49:45]

Description was changed from

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9.
 
Add default QP scaling threshold for VP9.
 
BUG=webrtc:7662
==========

to

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9.
 
Add default QP scaling thresholds for VP9.
 
BUG=webrtc:7662
==========

[åsapersson, 2017-06-05 14:40:26]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org, magjed@webrtc.org

[brandtr, 2017-06-05 14:49:35]

lgtm

[magjed_webrtc, 2017-06-05 15:40:21]

This CL will also turn on quality scaling for Android HW VP9. Do we have any
other encoders where we should turn it on?

[magjed_webrtc, 2017-06-05 15:40:30]

magjed@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[åsapersson, 2017-06-07 05:48:08]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 05:48:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-07 06:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 06:11:58]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-06-07 07:02:08]

Description was changed from

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9.
 
Add default QP scaling thresholds for VP9.
 
BUG=webrtc:7662
==========

to

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9 and turn on
quality scaling.
 
Add default QP scaling thresholds for VP9.
 
BUG=webrtc:7662
==========

[åsapersson, 2017-06-07 07:06:58]

On 2017/06/05 15:40:21, magjed_webrtc wrote:
> This CL will also turn on quality scaling for Android HW VP9. Do we have any
> other encoders where we should turn it on?

Internal resize is enabled for libvpx VP9.

[brandtr, 2017-06-07 09:16:45]

On 2017/06/05 15:40:21, magjed_webrtc wrote:
> This CL will also turn on quality scaling for Android HW VP9. Do we have any
> other encoders where we should turn it on?

Enabling the quality scaling in this CL is intentional. If we want to enable it
for other encoders too, we could consider doing that separately.

[magjed_webrtc, 2017-06-07 10:58:19]

lgtm

[kthelgason, 2017-06-07 11:00:42]

lgtm

[åsapersson, 2017-06-07 11:07:42]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2017-06-07 11:07:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-07 11:09:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496833662687820,
"parent_rev": "3e35a3cfd99e11ab74b1ac9ceaa5871164aa80d3", "commit_rev":
"1e15a994ac668d37d8b2d7bbcf4864635e3fb3f3"}

[commit-bot: I haz the power, 2017-06-07 11:09:51]

Description was changed from

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9 and turn on
quality scaling.
 
Add default QP scaling thresholds for VP9.
 
BUG=webrtc:7662
==========

to

==========
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9 and turn on
quality scaling.
 
Add default QP scaling thresholds for VP9.
 
BUG=webrtc:7662

Review-Url: https://codereview.webrtc.org/2914363002
Cr-Commit-Position: refs/heads/master@{#18469}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1e15a994ac668d37d8b2d7bbc...
==========

[commit-bot: I haz the power, 2017-06-07 11:09:52]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1e15a994ac668d37d8b2d7bbc...