Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2913793002: Address some violations of chromium-style. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe.h
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.h b/webrtc/modules/congestion_controller/delay_based_bwe.h
index 0fb778b9b302610c708ce91c0c2824ed4b25815b..eccd73ac4d49f7daea6b7fd1ae7366b6e6089d50 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe.h
+++ b/webrtc/modules/congestion_controller/delay_based_bwe.h
@@ -45,7 +45,7 @@ class DelayBasedBwe {
};
DelayBasedBwe(RtcEventLog* event_log, const Clock* clock);
- virtual ~DelayBasedBwe() {}
kwiberg-webrtc 2017/05/31 08:22:27 Hmm. Why is this destructor virtual? Nothing else
nisse-webrtc 2017/05/31 08:44:54 No idea, I'm afraid. Do you want me to change it?
kwiberg-webrtc 2017/05/31 08:49:48 No, at least not in this CL. I was just asking in
+ virtual ~DelayBasedBwe();
Result IncomingPacketFeedbackVector(
const std::vector<PacketFeedback>& packet_feedback_vector);

Powered by Google App Engine
This is Rietveld 408576698