Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2912443002: Remove unwanted temp variable (Closed)

Created:
3 years, 7 months ago by naga
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unwanted temp variable Remove unwanted temp variable usage in WriteUnicodeLE. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/http/http_auth_handler_ntlm_portable.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Shanmuga Pandi
Peer review l-g-t-m.
3 years, 6 months ago (2017-05-30 07:29:44 UTC) #3
palmer
lgarron and I are not OWNERS of net/http.
3 years, 6 months ago (2017-05-30 19:00:43 UTC) #6
Shanmuga Pandi
Adding mattm@ and bnc@ to review.
3 years, 6 months ago (2017-06-07 11:15:00 UTC) #9
mattm
3 years, 6 months ago (2017-06-07 20:36:01 UTC) #10 
not lgtm

As the comment says, the temp variable is to allow for the case where buf ==
str. cursor is a pointer into buf and input is a pointer into str.

Powered by Google App Engine
This is Rietveld 408576698