Fix automation API bounding boxes on high-dpi devices

Fix automation API bounding boxes on high-dpi devices

This regressed in r460412 (https://codereview.chromium.org/2762373002)
when we switched from taking the frame-relative coordinates of each web
object and adding a frame offset, to always just walking up the whole
accessibility tree to find the global bounds of an object.

The reason that failed is because the coordinates we get from the web
have the scale factor applied, but coordinates we get from the desktop
do not. So we need to "unapply" the device scale factor just once,
at the point we walk from the web tree to the desktop tree.

This regressed once before last year. This time I figured out a way to add
a regression test for it.

BUG=726081
Review-Url: https://codereview.chromium.org/2911553002
Cr-Commit-Position: refs/heads/master@{#474967}
Committed: https://chromium.googlesource.com/chromium/src/+/cb19f7f0877982a0d5c326198eb3a67f366d4114

[dmazzoni, 2017-05-25 23:01:47]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:02:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-05-25 23:03:06]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2017-05-26 01:05:00]

lgtm

Could you add a comment answering my question below?

https://codereview.chromium.org/2911553002/diff/1/chrome/renderer/extensions/...
File chrome/renderer/extensions/automation_internal_custom_bindings.cc (right):

https://codereview.chromium.org/2911553002/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:131:
TreeCache* previous_cache = cache;
Where does cache get mutated?

[commit-bot: I haz the power, 2017-05-26 01:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:13:25]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-05-26 06:41:30]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-26 06:41:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2911553002/#ps20001
(title: "Add comment about mutating cache")

[dmazzoni, 2017-05-26 06:41:34]

https://codereview.chromium.org/2911553002/diff/1/chrome/renderer/extensions/...
File chrome/renderer/extensions/automation_internal_custom_bindings.cc (right):

https://codereview.chromium.org/2911553002/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:131:
TreeCache* previous_cache = cache;
On 2017/05/26 01:04:59, aboxhall wrote:
> Where does cache get mutated?

Commented.

[commit-bot: I haz the power, 2017-05-26 06:41:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 08:25:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495780890790050,
"parent_rev": "ec3056b0028de68485f6e5c4b6d57f225d334605", "commit_rev":
"cb19f7f0877982a0d5c326198eb3a67f366d4114"}

[commit-bot: I haz the power, 2017-05-26 08:25:20]

Description was changed from

==========
Fix automation API bounding boxes on high-dpi devices

This regressed in r460412 (https://codereview.chromium.org/2762373002)
when we switched from taking the frame-relative coordinates of each web
object and adding a frame offset, to always just walking up the whole
accessibility tree to find the global bounds of an object.

The reason that failed is because the coordinates we get from the web
have the scale factor applied, but coordinates we get from the desktop
do not. So we need to "unapply" the device scale factor just once,
at the point we walk from the web tree to the desktop tree.

This regressed once before last year. This time I figured out a way to add
a regression test for it.

BUG=726081
==========

to

==========
Fix automation API bounding boxes on high-dpi devices

This regressed in r460412 (https://codereview.chromium.org/2762373002)
when we switched from taking the frame-relative coordinates of each web
object and adding a frame offset, to always just walking up the whole
accessibility tree to find the global bounds of an object.

The reason that failed is because the coordinates we get from the web
have the scale factor applied, but coordinates we get from the desktop
do not. So we need to "unapply" the device scale factor just once,
at the point we walk from the web tree to the desktop tree.

This regressed once before last year. This time I figured out a way to add
a regression test for it.

BUG=726081

Review-Url: https://codereview.chromium.org/2911553002
Cr-Commit-Position: refs/heads/master@{#474967}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb19f7f0877982a0d5c326198eb3...
==========

[commit-bot: I haz the power, 2017-05-26 08:25:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb19f7f0877982a0d5c326198eb3...