Implement timing frames.

webrtc/video/payload_router.cc

Index: webrtc/video/payload_router.cc
diff --git a/webrtc/video/payload_router.cc b/webrtc/video/payload_router.cc
index 52e9d46ebb4f594c4fbfa3d96b1753e0717dabdb..127f633dd92aceaffb6f090c514170811e0c8682 100644
--- a/webrtc/video/payload_router.cc
+++ b/webrtc/video/payload_router.cc
@@ -130,6 +130,21 @@ EncodedImageCallback::Result PayloadRouter::OnEncodedImage(
     CopyCodecSpecific(codec_specific_info, &rtp_video_header);
   rtp_video_header.rotation = encoded_image.rotation_;
   rtp_video_header.content_type = encoded_image.content_type_;
+  if (encoded_image.timing_.is_timing_frame) {
+    rtp_video_header.video_timing.encode_start_ms_delta =
+        VideoTiming::GetDeltaCappedMs(encoded_image.capture_time_ms_,
+                                      encoded_image.timing_.encode_start_ms);

[holmer, 2017/06/19 07:48:26]

Is there a reason why the delta is computed here and not when the
encode_start_ms timestamp is taken? AFAICT you might just as well do it there
already?

[ilnik, 2017/06/19 08:41:51]

Reason is: we have the same data-structure to store timestamps on sending time
and on receiving time in EncodedImage. Doing otherwise would require to separate
data-structures in EncodedImage for send and receive sides. Thus, we can't store
deltas in EncodedImage, and they are computed then rtp video header is formed.

[holmer, 2017/06/19 12:17:47]

Acknowledged.

+    rtp_video_header.video_timing.encode_finish_ms_delta =
+        VideoTiming::GetDeltaCappedMs(encoded_image.capture_time_ms_,
+                                      encoded_image.timing_.encode_finish_ms);
+    rtp_video_header.video_timing.packetization_finish_ms_delta = 0;
+    rtp_video_header.video_timing.pacer_exit_ms_delta = 0;
+    rtp_video_header.video_timing.network_timstamp_ms_delta = 0;
+    rtp_video_header.video_timing.network2_timstamp_ms_delta = 0;

[holmer, 2017/06/19 07:48:26]

Maybe add a default ctor which initializes everything to zero instead?

[ilnik, 2017/06/19 08:41:51]

Tried that, it causes some weird problems with RTPVideoHeader class:
error: [chromium-style] Complex class/struct needs an explicit out-of-line
constructor.

Adding there constructor seems like a too big of a change, it also creates a
cascade change to WebRtcRTPHeader and so on.

[holmer, 2017/06/19 12:17:47]

Acknowledged.

+    rtp_video_header.video_timing.is_timing_frame = true;
+  } else {
+    rtp_video_header.video_timing.is_timing_frame = false;
+  }
   rtp_video_header.playout_delay = encoded_image.playout_delay_;
 
   int stream_index = rtp_video_header.simulcastIdx;