Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/test/fake_encoder.cc

Issue 2911193002: Implement timing frames. (Closed)
Patch Set: Implement Asapersson@ comments and foolproof generic encoder to be used in tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/common_types.h ('K') | « webrtc/test/constants.cc ('k') | webrtc/test/frame_generator_capturer.cc » ('j') | webrtc/video/payload_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/fake_encoder.cc
diff --git a/webrtc/test/fake_encoder.cc b/webrtc/test/fake_encoder.cc
index fce12c61a804c8af841435b001779374b912066c..a76ac131d1b77fa1d53640d9f36c9177566ec2e6 100644
--- a/webrtc/test/fake_encoder.cc
+++ b/webrtc/test/fake_encoder.cc
@@ -148,6 +148,7 @@ int32_t FakeEncoder::Encode(const VideoFrame& input_image,
? VideoContentType::SCREENSHARE
: VideoContentType::UNSPECIFIED;
specifics.codec_name = ImplementationName();
+ specifics.codecSpecific.generic.simulcast_idx = i;
holmer 2017/06/19 07:48:26 Is this fixing a test bug?
ilnik 2017/06/19 08:41:51 Yes, new logic in this CL requires some kind of si
RTC_DCHECK(callback);
if (callback->OnEncodedImage(encoded, &specifics, nullptr).error !=
EncodedImageCallback::Result::OK) {
« webrtc/common_types.h ('K') | « webrtc/test/constants.cc ('k') | webrtc/test/frame_generator_capturer.cc » ('j') | webrtc/video/payload_router.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698