Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2911013002:
Add fuzzer for vp9 qp parser. (Closed)
|
Created:
3 years, 6 months ago by åsapersson Modified:
3 years, 6 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd fuzzer for vp9 qp parser.
Return false if ReadBits fails.
Prevents GetQp from returning true with a qp of zero.
BUG=webrtc:7662
Review-Url: https://codereview.webrtc.org/2911013002
Cr-Commit-Position: refs/heads/master@{#18462}
Committed: https://chromium.googlesource.com/external/webrtc/+/23ec19dbb9046bd00655b1c065f2400bcc3cf8da
Patch Set 1 #
Total comments: 3
Patch Set 2 : address comment #Patch Set 3 : update Vp9ReadProfile #Patch Set 4 : rebase #
Messages
Total messages: 38 (27 generated)
Description was changed from ========== Return false if ReadBits fails. BUG= ========== to ========== Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG= ==========
Patchset #3 (id:20002) has been deleted
Description was changed from ========== Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG= ========== to ========== Add fuzzer for vp9 qp parser. Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG=webrtc:7662 ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org, jianj@chromium.org
Patchset #3 (id:50001) has been deleted
asapersson@webrtc.org changed reviewers: + kjellander@webrtc.org
https://codereview.webrtc.org/2911013002/diff/70001/webrtc/modules/video_codi... File webrtc/modules/video_coding/utility/vp9_uncompressed_header_parser.cc (right): https://codereview.webrtc.org/2911013002/diff/70001/webrtc/modules/video_codi... webrtc/modules/video_coding/utility/vp9_uncompressed_header_parser.cc:39: if (*profile > kVp9MaxProfile) { Can this happen? Max profile here 4?
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
rubberstamp lgtm for webrtc/test
Looks good. Can you run the tests in https://codereview.webrtc.org/2903163002/ and see if they pass after this change? https://codereview.webrtc.org/2911013002/diff/70001/webrtc/modules/video_codi... File webrtc/modules/video_coding/utility/vp9_uncompressed_header_parser.cc (right): https://codereview.webrtc.org/2911013002/diff/70001/webrtc/modules/video_codi... webrtc/modules/video_coding/utility/vp9_uncompressed_header_parser.cc:126: if (!Vp9ReadFrameSize(br)) Add {} to make it easier to read.
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Have verified that the tests in https://codereview.webrtc.org/2903163002/ passes. https://codereview.webrtc.org/2911013002/diff/70001/webrtc/modules/video_codi... File webrtc/modules/video_coding/utility/vp9_uncompressed_header_parser.cc (right): https://codereview.webrtc.org/2911013002/diff/70001/webrtc/modules/video_codi... webrtc/modules/video_coding/utility/vp9_uncompressed_header_parser.cc:126: if (!Vp9ReadFrameSize(br)) On 2017/05/30 15:13:49, brandtr wrote: > Add {} to make it easier to read. Done.
Good idea with the fuzzer! lgtm
asapersson@webrtc.org changed reviewers: + marpan@webrtc.org
jianj/marpan: can you please have a look.
jianj@google.com changed reviewers: + jianj@google.com
lgtm
Have made a change to Vp9ReadProfile, ptal.
The change looks OK. lgtm
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
Patchset #4 (id:130001) has been deleted
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org, brandtr@webrtc.org, jianj@google.com, jianj@chromium.org Link to the patchset: https://codereview.webrtc.org/2911013002/#ps150001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 150001, "attempt_start_ts": 1496817592214640,
"parent_rev": "5f200f6fc174736fd8265aa656568c3436e27782", "commit_rev":
"23ec19dbb9046bd00655b1c065f2400bcc3cf8da"}
Message was sent while issue was closed.
Description was changed from ========== Add fuzzer for vp9 qp parser. Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG=webrtc:7662 ========== to ========== Add fuzzer for vp9 qp parser. Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG=webrtc:7662 Review-Url: https://codereview.webrtc.org/2911013002 Cr-Commit-Position: refs/heads/master@{#18462} Committed: https://chromium.googlesource.com/external/webrtc/+/23ec19dbb9046bd00655b1c06... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:150001) as https://chromium.googlesource.com/external/webrtc/+/23ec19dbb9046bd00655b1c06... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
