Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2910863002: Definitions of video-codec name constants don't match their declarations (Closed)

Created:
3 years, 6 months ago by VladimirTechMan
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Definitions of video-codec name constants don't match their declarations Constants kRTCVp8CodecName, kRTCVp9CodecName, kRTCH264CodecName declared in RTCRtpCodecParameters.h were defined without the "RTC" part in their names, thus using them in the app code resulted in linking errors. This patch fixes the naming mismatch. BUG=webrtc:7721 Review-Url: https://codereview.webrtc.org/2910863002 Cr-Commit-Position: refs/heads/master@{#18363} Committed: https://chromium.googlesource.com/external/webrtc/+/bf5a8010976227d2ab40e389a65bd6798d9fa830

Patch Set 1 #

Patch Set 2 : Fix definitions of video-codec name constants to match their declarations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
VladimirTechMan
3 years, 6 months ago (2017-05-28 18:25:01 UTC) #3
magjed_webrtc
lgtm
3 years, 6 months ago (2017-05-29 13:03:52 UTC) #4
VladimirTechMan
On 2017/05/29 13:03:52, magjed_webrtc wrote: > lgtm The patch updated to match the updated structure ...
3 years, 6 months ago (2017-05-30 17:02:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2910863002/20001
3 years, 6 months ago (2017-06-01 02:49:40 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 03:09:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/bf5a8010976227d2ab40e389a...

Powered by Google App Engine
This is Rietveld 408576698