Avoiding check on reordering configs in ANA if there is no controller has scoring point.

Avoiding check on reordering configs in ANA if there is no controller has scoring point.

BUG=webrtc:7729
Review-Url: https://codereview.webrtc.org/2910193002
Cr-Commit-Position: refs/heads/master@{#18331}
Committed: https://chromium.googlesource.com/external/webrtc/+/12de077b148dfb5106381ec629a1f574053fecdd

[minyue-webrtc, 2017-05-30 11:54:30]

Description was changed from

==========
Avoiding check on reordering configs in ANA if there is no controller has
scoring point.

BUG=
==========

to

==========
Avoiding check on reordering configs in ANA if there is no controller has
scoring point.

BUG=7729
==========

[minyue-webrtc, 2017-05-30 11:54:30]

minyue@webrtc.org changed reviewers:
+ michaelt@webrtc.org

[minyue-webrtc, 2017-05-30 11:58:55]

Hi Michael,

PTAL

[minyue-webrtc, 2017-05-30 12:02:12]

Description was changed from

==========
Avoiding check on reordering configs in ANA if there is no controller has
scoring point.

BUG=7729
==========

to

==========
Avoiding check on reordering configs in ANA if there is no controller has
scoring point.

BUG=webrtc:7729
==========

[minyue-webrtc, 2017-05-30 13:54:56]

minyue@webrtc.org changed reviewers:
+ tschumim@webrtc.org
- michaelt@webrtc.org

[tschumi, 2017-05-30 14:03:24]

https://codereview.webrtc.org/2910193002/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc
(right):

https://codereview.webrtc.org/2910193002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc:256: if
(chracteristic_points.size() == 0) {
Do you think its worth the extra complexity ?

[minyue-webrtc, 2017-05-30 14:09:13]

On 2017/05/30 14:03:24, tschumi wrote:
>
https://codereview.webrtc.org/2910193002/diff/1/webrtc/modules/audio_coding/a...
> File webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc
> (right):
> 
>
https://codereview.webrtc.org/2910193002/diff/1/webrtc/modules/audio_coding/a...
> webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc:256:
if
> (chracteristic_points.size() == 0) {
> Do you think its worth the extra complexity ?

Yes, it would be poor to let user write min_ordering_time and squared_distance
if they are not used.

[tschumi, 2017-05-30 14:20:05]

Ok

[tschumi, 2017-05-30 14:20:12]

lgtm

[minyue-webrtc, 2017-05-30 14:30:11]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2017-05-30 14:30:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-30 14:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:40:44]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[minyue-webrtc, 2017-05-30 15:11:31]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2017-05-30 15:11:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tschumim@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2910193002/#ps20001 (title:
"rebasing")

[commit-bot: I haz the power, 2017-05-30 15:11:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-30 15:56:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496157091039050,
"parent_rev": "d4d2ecec18f8d1af7fad45f6c4f5cfe05e32706b", "commit_rev":
"12de077b148dfb5106381ec629a1f574053fecdd"}

[commit-bot: I haz the power, 2017-05-30 15:56:12]

Description was changed from

==========
Avoiding check on reordering configs in ANA if there is no controller has
scoring point.

BUG=webrtc:7729
==========

to

==========
Avoiding check on reordering configs in ANA if there is no controller has
scoring point.

BUG=webrtc:7729

Review-Url: https://codereview.webrtc.org/2910193002
Cr-Commit-Position: refs/heads/master@{#18331}
Committed:
https://chromium.googlesource.com/external/webrtc/+/12de077b148dfb5106381ec62...
==========

[commit-bot: I haz the power, 2017-05-30 15:56:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/12de077b148dfb5106381ec62...