Avoid to build most of webrtc/sdk in chromium

Avoid to build most of webrtc/sdk in chromium

BUG=webrtc:4867
NOTRY=True

Review-Url: https://codereview.webrtc.org/2910153003
Cr-Commit-Position: refs/heads/master@{#18349}
Committed: https://chromium.googlesource.com/external/webrtc/+/2c8ac1beda6bc30a7509a122f97404a5c89dd577

[mbonadei, 2017-05-30 13:58:36]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2017-05-30 13:58:36]

I ran 'gn format' on webrtc/sdk/BUILD.gn.
This is why it is changed so much. Let me know if you prefer
to avoid.

[kjellander_webrtc, 2017-05-30 14:13:10]

On 2017/05/30 13:58:36, mbonadei wrote:
> I ran 'gn format' on webrtc/sdk/BUILD.gn.
> This is why it is changed so much. Let me know if you prefer
> to avoid.

I'm confused. the //webrtc/test/BUILD.gn change should go away if you rebase
after submitting https://codereview.webrtc.org/2908973005/, right?
The rest should already be covered by gn format since AFAIK it always runs as
part of PRESUBMIT.py everywhere. If not, I'd like to see at least a separate
patch set with only gn format run, since it's impossible to review the current
diff.

[mbonadei, 2017-05-30 14:19:45]

On 2017/05/30 14:13:10, kjellander_webrtc wrote:
> On 2017/05/30 13:58:36, mbonadei wrote:
> > I ran 'gn format' on webrtc/sdk/BUILD.gn.
> > This is why it is changed so much. Let me know if you prefer
> > to avoid.
> 
> I'm confused. the //webrtc/test/BUILD.gn change should go away if you rebase
> after submitting https://codereview.webrtc.org/2908973005/, right?

I was confused too. The explanation is that these two absolute path are
inside "if (!build_with_chromium)" so they escaped the other CL.

> The rest should already be covered by gn format since AFAIK it always runs as
> part of PRESUBMIT.py everywhere. If not, I'd like to see at least a separate
> patch set with only gn format run, since it's impossible to review the current
> diff.

Ok, I agree.

[mbonadei, 2017-05-30 14:21:08]

io-device is red because I have been too eager with this change.

webrtc/sdk:objc_framework is in the webrtc/sdk:sdk target. Should
I move also this one into the if?

[kjellander_webrtc, 2017-05-30 14:31:16]

On 2017/05/30 14:21:08, mbonadei wrote:
> io-device is red because I have been too eager with this change.
> 
> webrtc/sdk:objc_framework is in the webrtc/sdk:sdk target. Should
> I move also this one into the if?

Yeah, I forgot to say you need to update the 'sdk' target as well with similar
conditions so the targets in there are available

[kjellander_webrtc, 2017-05-31 11:07:54]

lgtm since I trust you on that the diff is only about indentation and the
changes are just moving targets into conditional blocks.

[mbonadei, 2017-05-31 11:14:19]

Description was changed from

==========
Avoid to build most of webrtc/sdk in chromium

BUG=None
NOTRY=True
==========

to

==========
Avoid to build most of webrtc/sdk in chromium

BUG=webrtc:4867
NOTRY=True
==========

[mbonadei, 2017-05-31 12:12:19]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-05-31 12:12:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-31 12:14:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496232739472900,
"parent_rev": "2b356ae664094d2f03b679a852fe6f1a12b58ad1", "commit_rev":
"2c8ac1beda6bc30a7509a122f97404a5c89dd577"}

[commit-bot: I haz the power, 2017-05-31 12:14:30]

Description was changed from

==========
Avoid to build most of webrtc/sdk in chromium

BUG=webrtc:4867
NOTRY=True
==========

to

==========
Avoid to build most of webrtc/sdk in chromium

BUG=webrtc:4867
NOTRY=True

Review-Url: https://codereview.webrtc.org/2910153003
Cr-Commit-Position: refs/heads/master@{#18349}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2c8ac1beda6bc30a7509a122f...
==========

[commit-bot: I haz the power, 2017-05-31 12:14:31]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/2c8ac1beda6bc30a7509a122f...