Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2909753002: Tightening checks in ChromeContentBrowserClientExtensionsPart::CanCommitURL

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 2 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tightening checks in ChromeContentBrowserClientExtensionsPart::CanCommitURL Since --isolate-extensions has shipped in M58, we should be able to enforce stricter CanCommitURL checks and disallow extension frames from committing outside of an extension process. BUG=TODO/DO NOT SUBMIT

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 22:59:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909753002/1
3 years, 7 months ago (2017-05-26 22:59:54 UTC) #2
Łukasz Anforowicz
Description was changed from ========== Tightening checks in ChromeContentBrowserClientExtensionsPart::CanCommitURL BUG=TODO/DO NOT SUBMIT ========== to ========== ...
3 years, 7 months ago (2017-05-26 23:00:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 23:42:59 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 23:43:00 UTC) #5
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698