third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp - Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

index cd0a108eb988ad8e718cee8bf8218c1e2bced0de..f56c4c12c5d1b8777929b08471c4a4ea710d68f9 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

@@ -331,7 +331,7 @@ void ResourceFetcher::RequestLoadStarted(unsigned long identifier,

PopulateTimingInfo(info.Get(), resource);

info->ClearLoadTimings();

info->SetLoadFinishTime(info->InitialTime());

- scheduled_resource_timing_reports_.push_back(info.Release());

+ scheduled_resource_timing_reports_.push_back(std::move(info));

if (!resource_timing_report_timer_.IsActive())

resource_timing_report_timer_.StartOneShot(0, BLINK_FROM_HERE);

}

@@ -840,7 +840,7 @@ void ResourceFetcher::StorePerformanceTimingInitiatorInformation(

if (!is_main_resource ||

Context().UpdateTimingInfoForIFrameNavigation(info.Get())) {

- resource_timing_info_map_.insert(resource, info.Release());

+ resource_timing_info_map_.insert(resource, std::move(info));

}