gpu: GpuProcessHost does not need to remember the GPUInfo.

gpu: GpuProcessHost does not need to remember the GPUInfo.

Remove GpuProcessHost::gpu_info_, since it is used only one place, and
it is possible to get that information directly from GpuDataManagerImpl.
Also, it was possible for GpuProcessHost::gpu_info_ to be different from
the GPUInfo the rest of the systems see through GpuDataManager[Impl]. So
remove it instead, and have a single source for the GPUInfo.

BUG=none

Review-Url: https://codereview.chromium.org/2909483004
Cr-Commit-Position: refs/heads/master@{#475316}
Committed: https://chromium.googlesource.com/chromium/src/+/2da4c09d784da8f90c2e41418e92533abb9f5612

[sadrul, 2017-05-25 22:51:00]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:52:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 23:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 23:30:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sadrul, 2017-05-26 02:49:52]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 02:50:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 04:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 04:59:45]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-05-26 05:31:29]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 05:32:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 07:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 07:03:23]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-05-26 21:42:47]

Description was changed from

==========
exp: GpuProcessHost does not need to remember the GpuInfo.

...

BUG=...
==========

to

==========
gpu: GpuProcessHost does not need to remember the GPUInfo.

Remove GpuProcessHost::gpu_info_, since it is used only one place, and
it is possible to get that information directly from GpuDataManagerImpl. Also,
it was possible for GpuProcessHost::gpu_info_ to be different from
the GPUInfo the rest of the systems see through GpuDataManager[Impl]. So
remove it instead, and have a single source for the GPUInfo.

BUG=none
==========

[sadrul, 2017-05-26 21:42:59]

Description was changed from

==========
gpu: GpuProcessHost does not need to remember the GPUInfo.

Remove GpuProcessHost::gpu_info_, since it is used only one place, and
it is possible to get that information directly from GpuDataManagerImpl. Also,
it was possible for GpuProcessHost::gpu_info_ to be different from
the GPUInfo the rest of the systems see through GpuDataManager[Impl]. So
remove it instead, and have a single source for the GPUInfo.

BUG=none
==========

to

==========
gpu: GpuProcessHost does not need to remember the GPUInfo.

Remove GpuProcessHost::gpu_info_, since it is used only one place, and
it is possible to get that information directly from GpuDataManagerImpl.
Also, it was possible for GpuProcessHost::gpu_info_ to be different from
the GPUInfo the rest of the systems see through GpuDataManager[Impl]. So
remove it instead, and have a single source for the GPUInfo.

BUG=none
==========

[sadrul, 2017-05-26 21:43:13]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2017-05-26 22:08:05]

LGTM I guess. I'm always reluctant to use GpuDataManagerImpl(Private) as a
source of truth because it is fundamentally racy (some things happen on the IO
thread, some happen on the UI thread). In the case of GPUInfo, it looks like for
the most part it happens on the IO thread, so it should be ok - with the caveat
that as the GPUInfo is updated asynchronously, different channels on the same
gpu process may see different GPUInfos. Is that better or worse I don't know.

I suppose some of this weirdness will go away as we move most (all?) of the
GpuDataManagerImpl logic into the GPU process, so the info that GpuProcessHost
receives will be consistent with the rest of the system (and may actually become
the one true source for the browser process).

[sadrul, 2017-05-29 08:06:52]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-05-29 08:07:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 09:04:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496045212853720,
"parent_rev": "f01f939a453471ba2924549c7f4c3d80eca3189a", "commit_rev":
"2da4c09d784da8f90c2e41418e92533abb9f5612"}

[commit-bot: I haz the power, 2017-05-29 09:04:26]

Description was changed from

==========
gpu: GpuProcessHost does not need to remember the GPUInfo.

Remove GpuProcessHost::gpu_info_, since it is used only one place, and
it is possible to get that information directly from GpuDataManagerImpl.
Also, it was possible for GpuProcessHost::gpu_info_ to be different from
the GPUInfo the rest of the systems see through GpuDataManager[Impl]. So
remove it instead, and have a single source for the GPUInfo.

BUG=none
==========

to

==========
gpu: GpuProcessHost does not need to remember the GPUInfo.

Remove GpuProcessHost::gpu_info_, since it is used only one place, and
it is possible to get that information directly from GpuDataManagerImpl.
Also, it was possible for GpuProcessHost::gpu_info_ to be different from
the GPUInfo the rest of the systems see through GpuDataManager[Impl]. So
remove it instead, and have a single source for the GPUInfo.

BUG=none

Review-Url: https://codereview.chromium.org/2909483004
Cr-Commit-Position: refs/heads/master@{#475316}
Committed:
https://chromium.googlesource.com/chromium/src/+/2da4c09d784da8f90c2e41418e92...
==========

[commit-bot: I haz the power, 2017-05-29 09:04:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2da4c09d784da8f90c2e41418e92...