Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2909343002: Have audio_device only depend on X11 if use_x11 is set. (Closed)

Created:
3 years, 6 months ago by kjellander_webrtc
Modified:
3 years, 6 months ago
Reviewers:
niklas.enbom
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Have audio_device only depend on X11 if use_x11 is set. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2909343002 Cr-Commit-Position: refs/heads/master@{#18335} Committed: https://chromium.googlesource.com/external/webrtc/+/c41d0c49130924d7e97d293f98daeab721ab090f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
3 years, 6 months ago (2017-05-30 18:04:00 UTC) #2
niklas.enbom
lgtm On 2017/05/30 18:04:00, kjellander_webrtc wrote:
3 years, 6 months ago (2017-05-30 18:52:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2909343002/1
3 years, 6 months ago (2017-05-30 19:03:54 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 19:06:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c41d0c49130924d7e97d293f9...

Powered by Google App Engine
This is Rietveld 408576698