Fixing absolute path that was breaking chromium

Fixing absolute path that was breaking chromium

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2908973005
Cr-Commit-Position: refs/heads/master@{#18328}
Committed: https://chromium.googlesource.com/external/webrtc/+/07502d4f146c503ed4b1722a34e08e93fc56b055

[mbonadei, 2017-05-30 12:34:45]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2017-05-30 12:34:45]

The previous roll in chromium is failing because of an absolute
path.

This CL makes the path relative.

[kjellander_webrtc, 2017-05-30 12:37:05]

On 2017/05/30 12:34:45, mbonadei wrote:
> The previous roll in chromium is failing because of an absolute
> path.
> 
> This CL makes the path relative.

Seems you need to follow dependencies too (ios-device failure)

[kjellander_webrtc, 2017-05-30 12:58:25]

https://codereview.webrtc.org/2908973005/diff/60001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2908973005/diff/60001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:191: "//webrtc/api:video_frame_api",
here's more.
I think you better fix the whole file.

[mbonadei, 2017-05-30 13:01:22]

On 2017/05/30 12:58:25, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2908973005/diff/60001/webrtc/sdk/BUILD.gn
> File webrtc/sdk/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2908973005/diff/60001/webrtc/sdk/BUILD.gn#newco...
> webrtc/sdk/BUILD.gn:191: "//webrtc/api:video_frame_api",
> here's more.
> I think you better fix the whole file.

Yep, now the BUILD.gn file should be fine. We have some "unresolved
dependencies".

I will try to make them available.

[mbonadei, 2017-05-30 13:03:39]

On 2017/05/30 13:01:22, mbonadei wrote:
> On 2017/05/30 12:58:25, kjellander_webrtc wrote:
> > https://codereview.webrtc.org/2908973005/diff/60001/webrtc/sdk/BUILD.gn
> > File webrtc/sdk/BUILD.gn (right):
> > 
> >
>
https://codereview.webrtc.org/2908973005/diff/60001/webrtc/sdk/BUILD.gn#newco...
> > webrtc/sdk/BUILD.gn:191: "//webrtc/api:video_frame_api",
> > here's more.
> > I think you better fix the whole file.
> 
> Yep, now the BUILD.gn file should be fine. We have some "unresolved
> dependencies".
> 
> I will try to make them available.

It is easier than I was thinking. I introduced a typo in the common_video
dependency.

[kjellander_webrtc, 2017-05-30 13:09:32]

lgtm

[hbos, 2017-05-30 13:17:17]

hbos@webrtc.org changed reviewers:
+ hbos@webrtc.org

[hbos, 2017-05-30 13:17:18]

lgtm

[mbonadei, 2017-05-30 13:21:43]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-05-30 13:21:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-30 13:23:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496150503267600,
"parent_rev": "2d9e32e868d0b46d991b90f4f28e856091b91392", "commit_rev":
"07502d4f146c503ed4b1722a34e08e93fc56b055"}

[commit-bot: I haz the power, 2017-05-30 13:23:44]

Description was changed from

==========
Fixing absolute path that was breaking chromium

BUG=None
NOTRY=True
==========

to

==========
Fixing absolute path that was breaking chromium

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2908973005
Cr-Commit-Position: refs/heads/master@{#18328}
Committed:
https://chromium.googlesource.com/external/webrtc/+/07502d4f146c503ed4b1722a3...
==========

[commit-bot: I haz the power, 2017-05-30 13:23:45]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/07502d4f146c503ed4b1722a3...