Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2908723002: Partial network traffic annotation check for tests updated. (Closed)

Created:
3 years, 6 months ago by Ramin Halavati
Modified:
3 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial network traffic annotation check for tests updated. Partial network traffic annotation check updated to ignore passing correct completing id for test annotation tags. BUG=656607 Review-Url: https://codereview.chromium.org/2908723002 Cr-Commit-Position: refs/heads/master@{#475372} Committed: https://chromium.googlesource.com/chromium/src/+/d512ea39107a9cbad6936a9e98ea9214116433d8

Patch Set 1 #

Patch Set 2 : Merged. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M net/traffic_annotation/network_traffic_annotation.h View 2 chunks +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Ramin Halavati
Helen, I made a minor change in functions defining partial network traffic annotation. This change ...
3 years, 6 months ago (2017-05-29 14:43:43 UTC) #2
xunjieli
lgtm
3 years, 6 months ago (2017-05-29 18:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908723002/20001
3 years, 6 months ago (2017-05-29 18:10:04 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 19:27:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d512ea39107a9cbad6936a9e98ea...

Powered by Google App Engine
This is Rietveld 408576698