Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2908013002: Add media constraint-key constants for generating offers and answers (Closed)

Created:
3 years, 6 months ago by VladimirTechMan
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add media constraint-key constants for generating offers and answers Similar to the existing constants for the media constraint-keys intended for media sources, add the constants for the standard keys to generate offers and answers. This patch also adds a few comments to RTCMediaConstraints.h, to give a better clue on the intended usage scope of declared media-constraint keys and values. BUG=webrtc:7722 Review-Url: https://codereview.webrtc.org/2908013002 Cr-Commit-Position: refs/heads/master@{#18362} Committed: https://chromium.googlesource.com/external/webrtc/+/7b3eca9940e4e9407df2024248a212063680b6d6

Patch Set 1 #

Patch Set 2 : Add media constraint-key constants for generating offers and answers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
VladimirTechMan
3 years, 6 months ago (2017-05-28 22:27:33 UTC) #3
magjed_webrtc
lgtm
3 years, 6 months ago (2017-05-29 13:02:28 UTC) #4
VladimirTechMan
On 2017/05/29 13:02:28, magjed_webrtc wrote: > lgtm The patch updated to match the updated structure ...
3 years, 6 months ago (2017-05-30 17:12:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2908013002/20001
3 years, 6 months ago (2017-06-01 01:04:41 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 01:25:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7b3eca9940e4e9407df202424...

Powered by Google App Engine
This is Rietveld 408576698