Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issue 2907403003: Drop the rtp_rtcp module's dependency on call. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop the rtp_rtcp module's dependency on call. Also deletes a couple of includes of call.h, which seem unnecessary. BUG=None Review-Url: https://codereview.webrtc.org/2907403003 Cr-Commit-Position: refs/heads/master@{#18340} Committed: https://chromium.googlesource.com/external/webrtc/+/6412e4c85fdde6e35d870cce150813fe3b4a0591

Patch Set 1 #

Patch Set 2 : Also drop gn dependency on call_interfaces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
nisse-webrtc
PTAL. Do you know if there's any bug filed for breaking this dependency?
3 years, 6 months ago (2017-05-30 15:17:20 UTC) #3
danilchap
lgtm nice finding!
3 years, 6 months ago (2017-05-30 15:29:25 UTC) #4
kjellander_webrtc
lgtm I'm not aware of any bug, since this wasn't a cyclic dependency or something ...
3 years, 6 months ago (2017-05-30 17:41:35 UTC) #9
kjellander_webrtc
lgtm I'm not aware of any bug, since this wasn't a cyclic dependency or something ...
3 years, 6 months ago (2017-05-30 17:41:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2907403003/20001
3 years, 6 months ago (2017-05-31 06:36:33 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 06:38:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6412e4c85fdde6e35d870cce1...

Powered by Google App Engine
This is Rietveld 408576698