Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2906023002: [CSS Typed OM] Fix test bug errors, remove forgotten expectation files (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
Reviewers:
Bugs Nash
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Fix test bug errors, remove forgotten expectation files Someone made "null" as the expectation for assert_throws invalid (it was valid previously), so our tests recently started failing with the error "Test bug: ...". These tests now all pass, so the expectation file can be deleted. - computedStylePropertyMap.html - cssMatrixComponent.html - cssScale.html Delete some expectation files were missed when I deleted some tests. - cssCalcLength-expected.txt - cssSimpleLength-expected.txt BUG=545318 Review-Url: https://codereview.chromium.org/2906023002 Cr-Commit-Position: refs/heads/master@{#475287} Committed: https://chromium.googlesource.com/chromium/src/+/3ecac93803273c7b0fccd67e575f4f5101bfea5b

Patch Set 1 #

Total comments: 6

Messages

Total messages: 14 (8 generated)
meade_UTC10
This CL is a test cleanup. PTAL
3 years, 6 months ago (2017-05-26 06:39:49 UTC) #3
Bugs Nash
yay to more specific exception expectations! could you please clarify what you mean by null ...
3 years, 6 months ago (2017-05-29 01:30:41 UTC) #4
meade_UTC10
I tried to clarify the description a bit. PTAL. Thanks! https://codereview.chromium.org/2906023002/diff/1/third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap-expected.txt File third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap-expected.txt (left): https://codereview.chromium.org/2906023002/diff/1/third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap-expected.txt#oldcode1 ...
3 years, 6 months ago (2017-05-29 03:23:50 UTC) #6
Bugs Nash
lgtm
3 years, 6 months ago (2017-05-29 03:35:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906023002/1
3 years, 6 months ago (2017-05-29 03:39:06 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 04:53:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ecac93803273c7b0fccd67e575f...

Powered by Google App Engine
This is Rietveld 408576698