Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2905823003: Replaced usage of RefPtr::Release with std::move wraps in Source/core. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-style_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, falken+watch_chromium.org, horo+watch_chromium.org, kinuko+worker_chromium.org, Navid Zolghadr, rwlbuis, shimazu+worker_chromium.org, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced usage of RefPtr::Release with std::move wraps in Source/core. These wraps were overlooked in crrev.com/2622043003. Replaces many of the calls to RefPtr::Release with a std::move wrap, which returns a RefPtr instead of a PassRefPtr. As the code currently stands, most methods still expect a PassRefPtr and so the RefPtr is implicitly converted to a PassRefPtr. Future patches will change the types passed from PassRefPtr to RefPtr. Does not handle RefPtr::Release calls in return statements that default to move. This will be handled in a future patch. BUG=494719 Review-Url: https://codereview.chromium.org/2905823003 Cr-Commit-Position: refs/heads/master@{#474932} Committed: https://chromium.googlesource.com/chromium/src/+/f8c074e1ab2eb9b1ff6a45567a7f94b70b1430a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Bugs Nash
3 years, 7 months ago (2017-05-26 03:51:26 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-26 03:57:58 UTC) #5
Yuta Kitamura
lgtm
3 years, 7 months ago (2017-05-26 05:47:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905823003/1
3 years, 7 months ago (2017-05-26 05:47:36 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 05:54:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8c074e1ab2eb9b1ff6a45567a7f...

Powered by Google App Engine
This is Rietveld 408576698