Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2905493008: Make TextIndentType an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, shans, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextIndentType an enum class. This patch makes TextIndentType an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2905493008 Cr-Commit-Position: refs/heads/master@{#474950} Committed: https://chromium.googlesource.com/chromium/src/+/4fc6f8be92035e4c30a39e6194e999259287020d

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 22 (16 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-26 00:48:13 UTC) #3
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-26 01:50:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905493008/1
3 years, 7 months ago (2017-05-26 04:20:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/448409)
3 years, 7 months ago (2017-05-26 04:29:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905493008/20001
3 years, 7 months ago (2017-05-26 07:01:02 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 07:06:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4fc6f8be92035e4c30a39e6194e9...

Powered by Google App Engine
This is Rietveld 408576698