Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2904883002: AudioEncoderPcm16B: Number of bits/sample is 16, not 2 (Closed)

Created:
3 years, 7 months ago by kwiberg-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

AudioEncoderPcm16B: Number of bits/sample is 16, not 2 Clearly, this was a case of bit/byte confusion. BUG=none Review-Url: https://codereview.webrtc.org/2904883002 Cr-Commit-Position: refs/heads/master@{#18254} Committed: https://chromium.googlesource.com/external/webrtc/+/0afb13014b370be8a7367053beadfca2cf3a8f89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
kwiberg-webrtc
3 years, 7 months ago (2017-05-24 10:32:01 UTC) #4
ossu
Yes, yes it was. Sorry about that! :) LGTM
3 years, 7 months ago (2017-05-24 10:43:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2904883002/1
3 years, 7 months ago (2017-05-24 11:08:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 11:09:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0afb13014b370be8a7367053b...

Powered by Google App Engine
This is Rietveld 408576698