Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2904543003: Revert of Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. (patchset #3 id:40001 of https://codereview.webrtc.org/2885143006/ ) Reason for revert: Causes a new TSan race warning. Will reland after fixing. Note this is the same race as will be fixed by https://codereview.webrtc.org/2876273002/. Original issue's description: > Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. > > The deadlock occurs if the AsyncInvoker is destroyed on thread A while > a task on thread B is running, which AsyncInvokes a task back on thread > A. > > This was causing pending_invocations_ to end up negative, because > an AsyncClosure that's never added to a thread's message queue (due to > the "destroying_" flag) caused the count to be decremented but not > incremented. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2885143006 > Cr-Commit-Position: refs/heads/master@{#18225} > Committed: https://chromium.googlesource.com/external/webrtc/+/ef37ca5fb3431864130de3c2fd0ff865f9eb47dd TBR=nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2904543003 Cr-Commit-Position: refs/heads/master@{#18248} Committed: https://chromium.googlesource.com/external/webrtc/+/aea9293fd45bced832862d544f34888c07d7bf65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -51 lines) Patch
M webrtc/base/asyncinvoker.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/asyncinvoker.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M webrtc/base/asyncinvoker-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/thread_unittest.cc View 4 chunks +15 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Revert of Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations.
3 years, 7 months ago (2017-05-23 19:54:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2904543003/1
3 years, 7 months ago (2017-05-23 19:54:58 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 19:55:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/aea9293fd45bced832862d544...

Powered by Google App Engine
This is Rietveld 408576698