Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2903843002: Add JSON and MB configs for the internal iOS bots. (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add JSON and MB configs for the internal iOS bots. BUG=chromium:704912 NOTRY=True Review-Url: https://codereview.webrtc.org/2903843002 Cr-Commit-Position: refs/heads/master@{#18258} Committed: https://chromium.googlesource.com/external/webrtc/+/c5108786ebdd87bf54fb973f9506278737e99697

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
A tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json View 1 chunk +24 lines, -0 lines 1 comment Download
A tools_webrtc/ios/internal.tryserver.webrtc/ios_arm64.json View 1 chunk +24 lines, -0 lines 0 comments Download
M tools_webrtc/mb/mb_config.pyl View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
ehmaldonado_webrtc
PTAL
3 years, 7 months ago (2017-05-24 15:19:25 UTC) #13
kjellander_webrtc
lgtm, I added NOTRY=True for you.
3 years, 7 months ago (2017-05-24 15:34:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2903843002/40001
3 years, 7 months ago (2017-05-24 15:42:52 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/c5108786ebdd87bf54fb973f9506278737e99697
3 years, 7 months ago (2017-05-24 15:44:50 UTC) #20
kjellander_webrtc
3 years, 6 months ago (2017-06-01 11:35:35 UTC) #21
Message was sent while issue was closed.
realized I missed important points in here.

https://codereview.webrtc.org/2903843002/diff/40001/tools_webrtc/ios/internal...
File tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json (right):

https://codereview.webrtc.org/2903843002/diff/40001/tools_webrtc/ios/internal...
tools_webrtc/ios/internal.client.webrtc/iOS64_Debug.json:10:
"target_cpu=\"x64\"",
This should have been arm64 etc. Sorry for missing that - I'll fix in a new CL.

Powered by Google App Engine
This is Rietveld 408576698