Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2903313002: Disable SIGPIPE for sockets created on iOS. (Closed)

Created:
3 years, 6 months ago by Taylor Brandstetter
Modified:
3 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable SIGPIPE for sockets created on iOS. This can occur (and by default, terminates the process) for apps that don't use the "voip" UIBackgroundMode. We're already doing a similar thing on Linux (using MSG_NOSIGNAL for every packet sent). BUG=webrtc:7686 Review-Url: https://codereview.webrtc.org/2903313002 Cr-Commit-Position: refs/heads/master@{#18277} Committed: https://chromium.googlesource.com/external/webrtc/+/eae4564cb7dea3ad9f5963814e82fd823267ff89

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : Adding more information to comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/base/physicalsocketserver.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
pthatcher1
lgtm
3 years, 6 months ago (2017-05-26 22:45:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2903313002/40001
3 years, 6 months ago (2017-05-26 23:08:58 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 23:27:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/eae4564cb7dea3ad9f5963814...

Powered by Google App Engine
This is Rietveld 408576698